Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add version number to About page #11

Open
Pohli opened this issue Oct 14, 2024 · 1 comment
Open

Add version number to About page #11

Pohli opened this issue Oct 14, 2024 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@Pohli
Copy link

Pohli commented Oct 14, 2024

See title.

@Tomin1 Tomin1 added the enhancement New feature or request label Oct 15, 2024
@Tomin1
Copy link
Member

Tomin1 commented Oct 18, 2024

For reference, this is how Patience Deck does it:
https://github.com/Tomin1/patience-deck/blob/cb5af775dc39a1d2c645646de7e8a31fc184f3fe/rpm/patience-deck.spec#L47
https://github.com/Tomin1/patience-deck/blob/cb5af775dc39a1d2c645646de7e8a31fc184f3fe/src/patience-deck.cpp#L84
https://github.com/Tomin1/patience-deck/blob/cb5af775dc39a1d2c645646de7e8a31fc184f3fe/src/src.pro#L14
https://github.com/Tomin1/patience-deck/blob/cb5af775dc39a1d2c645646de7e8a31fc184f3fe/qml/pages/about/AboutPage.qml#L44

Of course Country Quiz doesn't have to do it exactly the same way but that is an option. The one thing I don't like is that this pulls git as a dependency of the package but I don't really see a way around that if the version number should include git tag or the commit if there is no matching tag.

@Tomin1 Tomin1 added good first issue Good for newcomers help wanted Extra attention is needed labels Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants