Skip to content

Commit f53d154

Browse files
committed
Fix datetime comparisons
Broken since 2021 (06d0a36) 😅
1 parent 342bf74 commit f53d154

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

json.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -207,11 +207,11 @@ func (r Test) cmpAsDatetimes(kind, want, have string) Test {
207207
if err != nil {
208208
return r.bug("Could not read %q as a datetime value for key %q", want, r.Key)
209209
}
210-
211-
haveT, err := time.Parse(layout, datetimeRepl.Replace(want))
210+
haveT, err := time.Parse(layout, datetimeRepl.Replace(have))
212211
if err != nil {
213212
return r.failf("Malformed output from your encoder: key %q is not a datetime: %q", r.Key, have)
214213
}
214+
215215
if !wantT.Equal(haveT) {
216216
return r.failf("Values for key %q don't match:\n"+
217217
" Expected: %v\n"+

json_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,14 +5,14 @@ import (
55
)
66

77
func TestCompareDatetime(t *testing.T) {
8-
t.Skip() // TODO
9-
108
tests := []struct {
119
kind, want, have string
1210
wantFail bool
1311
}{
1412
{"datetime", "2006-01-02T15:04:05.123Z", "2006-01-02T15:04:05.123Z", false},
1513
{"datetime", "2006-01-02T15:04:05.123Z", "2006-01-02T15:04:05", true},
14+
{"datetime", "2006-01-02T15:04:05+01:00", "2006-01-02T15:04:05+01:00", false},
15+
{"datetime", "2006-01-02T15:04:05+01:00", "2006-01-02T15:04:05+01:01", true},
1616
{"time-local", "15:04:05.123", "15:04:05.123", false},
1717
{"time-local", "15:04:05.123", "15:04:05", true},
1818
}

0 commit comments

Comments
 (0)