chore(code-scanning): Qodana-Alerts bereinigen (#75)

* chore(code-scanning): Qodana Alerts bereinigen

* chore(ci): PR Governance trigger

* ci(code-scanning): Zero-Gate fuer Qodana-Fix-PRs entkoppeln

---------

Co-authored-by: GitHub Copilot Agent <github-actions[bot]@users.noreply.github.com>

Author: tomtastisch

src/FileTypeDetection/Infrastructure/ArchiveInternals.vb

@@ -1,6 +1,8 @@
 Option Strict On
 Option Explicit On
 
+Imports System.IO
+
 Namespace Global.Tomtastisch.FileClassifier
     Friend Enum ArchiveContainerType
         Unknown = 0
@@ -46,14 +48,14 @@ Namespace Global.Tomtastisch.FileClassifier
         ReadOnly Property UncompressedSize As Long?
         ReadOnly Property CompressedSize As Long?
         ReadOnly Property LinkTarget As String
-        Function OpenStream() As System.IO.Stream
+        Function OpenStream() As Stream
     End Interface
 
     Friend Interface IArchiveBackend
         ReadOnly Property ContainerType As ArchiveContainerType
 
         Function Process(
-                         stream As System.IO.Stream,
+                         stream As Stream,
                          opt As FileTypeProjectOptions,
                          depth As Integer,
                          containerTypeValue As ArchiveContainerType,
@@ -91,7 +93,7 @@ Namespace Global.Tomtastisch.FileClassifier
             If data Is Nothing OrElse data.Length = 0 Then Return False
 
             Try
-                Using ms As New System.IO.MemoryStream(data, writable:=False)
+                Using ms As New MemoryStream(data, writable:=False)
                     Return TryDescribeStream(ms, opt, descriptor)
                 End Using
             Catch ex As Exception
@@ -101,7 +103,7 @@ Namespace Global.Tomtastisch.FileClassifier
             End Try
         End Function
 
-        Friend Shared Function TryDescribeStream(stream As System.IO.Stream, opt As FileTypeProjectOptions,
+        Friend Shared Function TryDescribeStream(stream As Stream, opt As FileTypeProjectOptions,
                                                  ByRef descriptor As ArchiveDescriptor) As Boolean
             descriptor = ArchiveDescriptor.UnknownDescriptor()
             If Not StreamGuard.IsReadable(stream) Then Return False
@@ -151,13 +153,13 @@ Namespace Global.Tomtastisch.FileClassifier
         Private Sub New()
         End Sub
 
-        Friend Shared Function ValidateArchiveStream(stream As System.IO.Stream, opt As FileTypeProjectOptions, depth As Integer,
+        Friend Shared Function ValidateArchiveStream(stream As Stream, opt As FileTypeProjectOptions, depth As Integer,
                                                      descriptor As ArchiveDescriptor) As Boolean
             Return ProcessArchiveStream(stream, opt, depth, descriptor, Nothing)
         End Function
 
         Friend Shared Function ProcessArchiveStream(
-                                                    stream As System.IO.Stream,
+                                                    stream As Stream,
                                                     opt As FileTypeProjectOptions,
                                                     depth As Integer,
                                                     descriptor As ArchiveDescriptor,
@@ -179,15 +181,15 @@ Namespace Global.Tomtastisch.FileClassifier
         Private Sub New()
         End Sub
 
-        Friend Shared Function TryExtractArchiveStreamToMemory(stream As System.IO.Stream, opt As FileTypeProjectOptions) _
+        Friend Shared Function TryExtractArchiveStreamToMemory(stream As Stream, opt As FileTypeProjectOptions) _
             As IReadOnlyList(Of ZipExtractedEntry)
             Dim descriptor As ArchiveDescriptor = Nothing
             Dim emptyResult As IReadOnlyList(Of ZipExtractedEntry) = Array.Empty(Of ZipExtractedEntry)()
             If Not ArchiveTypeResolver.TryDescribeStream(stream, opt, descriptor) Then Return emptyResult
             Return TryExtractArchiveStreamToMemory(stream, opt, descriptor)
         End Function
 
-        Friend Shared Function TryExtractArchiveStreamToMemory(stream As System.IO.Stream, opt As FileTypeProjectOptions,
+        Friend Shared Function TryExtractArchiveStreamToMemory(stream As Stream, opt As FileTypeProjectOptions,
                                                                descriptor As ArchiveDescriptor) _
             As IReadOnlyList(Of ZipExtractedEntry)
             Dim emptyResult As IReadOnlyList(Of ZipExtractedEntry) = Array.Empty(Of ZipExtractedEntry)()
@@ -220,14 +222,14 @@ Namespace Global.Tomtastisch.FileClassifier
             End Try
         End Function
 
-        Friend Shared Function TryExtractArchiveStream(stream As System.IO.Stream, destinationDirectory As String,
+        Friend Shared Function TryExtractArchiveStream(stream As Stream, destinationDirectory As String,
                                                        opt As FileTypeProjectOptions) As Boolean
             Dim descriptor As ArchiveDescriptor = Nothing
             If Not ArchiveTypeResolver.TryDescribeStream(stream, opt, descriptor) Then Return False
             Return TryExtractArchiveStream(stream, destinationDirectory, opt, descriptor)
         End Function
 
-        Friend Shared Function TryExtractArchiveStream(stream As System.IO.Stream, destinationDirectory As String,
+        Friend Shared Function TryExtractArchiveStream(stream As Stream, destinationDirectory As String,
                                                        opt As FileTypeProjectOptions, descriptor As ArchiveDescriptor) _
             As Boolean
             If Not StreamGuard.IsReadable(stream) Then Return False
@@ -237,25 +239,25 @@ Namespace Global.Tomtastisch.FileClassifier
 
             Dim destinationFull As String
             Try
-                destinationFull = System.IO.Path.GetFullPath(destinationDirectory)
+                destinationFull = Path.GetFullPath(destinationDirectory)
             Catch ex As Exception
                 LogGuard.Debug(opt.Logger, $"[ArchiveExtract] Ungueltiger Zielpfad: {ex.Message}")
                 Return False
             End Try
 
             If Not DestinationPathGuard.ValidateNewExtractionTarget(destinationFull, opt) Then Return False
 
-            Dim parent = System.IO.Path.GetDirectoryName(destinationFull)
+            Dim parent = Path.GetDirectoryName(destinationFull)
             If String.IsNullOrWhiteSpace(parent) Then Return False
 
             Dim stageDir = destinationFull & ".stage-" & Guid.NewGuid().ToString("N")
             Try
-                System.IO.Directory.CreateDirectory(parent)
-                System.IO.Directory.CreateDirectory(stageDir)
+                Directory.CreateDirectory(parent)
+                Directory.CreateDirectory(stageDir)
 
                 StreamGuard.RewindToStart(stream)
 
-                Dim stagePrefix = EnsureTrailingSeparator(System.IO.Path.GetFullPath(stageDir))
+                Dim stagePrefix = EnsureTrailingSeparator(Path.GetFullPath(stageDir))
                 Dim ok = ArchiveProcessingEngine.ProcessArchiveStream(
                     stream,
                     opt,
@@ -266,15 +268,15 @@ Namespace Global.Tomtastisch.FileClassifier
                                   End Function)
                 If Not ok Then Return False
 
-                System.IO.Directory.Move(stageDir, destinationFull)
+                Directory.Move(stageDir, destinationFull)
                 Return True
             Catch ex As Exception
                 LogGuard.Debug(opt.Logger, $"[ArchiveExtract] Fehler: {ex.Message}")
                 Return False
             Finally
-                If System.IO.Directory.Exists(stageDir) Then
+                If Directory.Exists(stageDir) Then
                     Try
-                        System.IO.Directory.Delete(stageDir, recursive:=True)
+                        Directory.Delete(stageDir, recursive:=True)
                     Catch
                     End Try
                 End If
@@ -292,7 +294,7 @@ Namespace Global.Tomtastisch.FileClassifier
 
             Dim targetPath As String
             Try
-                targetPath = System.IO.Path.GetFullPath(System.IO.Path.Combine(destinationPrefix, entryName))
+                targetPath = Path.GetFullPath(Path.Combine(destinationPrefix, entryName))
             Catch
                 Return False
             End Try
@@ -303,17 +305,17 @@ Namespace Global.Tomtastisch.FileClassifier
             End If
 
             If isDirectory Then
-                System.IO.Directory.CreateDirectory(targetPath)
+                Directory.CreateDirectory(targetPath)
                 Return True
             End If
 
             If Not ValidateEntrySize(entry, opt) Then Return False
 
-            Dim targetDir = System.IO.Path.GetDirectoryName(targetPath)
+            Dim targetDir = Path.GetDirectoryName(targetPath)
             If String.IsNullOrWhiteSpace(targetDir) Then Return False
-            System.IO.Directory.CreateDirectory(targetDir)
+            Directory.CreateDirectory(targetDir)
 
-            If System.IO.File.Exists(targetPath) OrElse System.IO.Directory.Exists(targetPath) Then
+            If File.Exists(targetPath) OrElse Directory.Exists(targetPath) Then
                 LogGuard.Warn(opt.Logger, "[ArchiveExtract] Kollision bei Zielpfad.")
                 Return False
             End If
@@ -323,8 +325,8 @@ Namespace Global.Tomtastisch.FileClassifier
                     If source Is Nothing OrElse Not source.CanRead Then Return False
                     Using _
                         target As _
-                            New System.IO.FileStream(targetPath, System.IO.FileMode.CreateNew, System.IO.FileAccess.Write, System.IO.FileShare.None,
-                                           InternalIoDefaults.FileStreamBufferSize, System.IO.FileOptions.SequentialScan)
+                            New FileStream(targetPath, FileMode.CreateNew, FileAccess.Write, FileShare.None,
+                                           InternalIoDefaults.FileStreamBufferSize, FileOptions.SequentialScan)
                         StreamBounds.CopyBounded(source, target, opt.MaxZipEntryUncompressedBytes)
                     End Using
                 End Using
@@ -413,12 +415,12 @@ Namespace Global.Tomtastisch.FileClassifier
         End Function
 
         Private Shared Function EnsureTrailingSeparator(dirPath As String) As String
-            If String.IsNullOrEmpty(dirPath) Then Return System.IO.Path.DirectorySeparatorChar.ToString()
-            If dirPath.EndsWith(System.IO.Path.DirectorySeparatorChar) OrElse dirPath.EndsWith(System.IO.Path.AltDirectorySeparatorChar) _
+            If String.IsNullOrEmpty(dirPath) Then Return Path.DirectorySeparatorChar.ToString()
+            If dirPath.EndsWith(Path.DirectorySeparatorChar) OrElse dirPath.EndsWith(Path.AltDirectorySeparatorChar) _
                 Then
                 Return dirPath
             End If
-            Return dirPath & System.IO.Path.DirectorySeparatorChar
+            Return dirPath & Path.DirectorySeparatorChar
         End Function
     End Class
 
@@ -429,14 +431,14 @@ Namespace Global.Tomtastisch.FileClassifier
         Friend Shared Function TryCollectFromFile(path As String, opt As FileTypeProjectOptions,
                                                   ByRef entries As IReadOnlyList(Of ZipExtractedEntry)) As Boolean
             entries = Array.Empty(Of ZipExtractedEntry)()
-            If String.IsNullOrWhiteSpace(path) OrElse Not System.IO.File.Exists(path) Then Return False
+            If String.IsNullOrWhiteSpace(path) OrElse Not File.Exists(path) Then Return False
             If opt Is Nothing Then Return False
 
             Try
                 Using _
                     fs As _
-                        New System.IO.FileStream(path, System.IO.FileMode.Open, System.IO.FileAccess.Read, System.IO.FileShare.Read,
-                                       InternalIoDefaults.FileStreamBufferSize, System.IO.FileOptions.SequentialScan)
+                        New FileStream(path, FileMode.Open, FileAccess.Read, FileShare.Read,
+                                       InternalIoDefaults.FileStreamBufferSize, FileOptions.SequentialScan)
                     Dim descriptor As ArchiveDescriptor = Nothing
                     If Not ArchiveTypeResolver.TryDescribeStream(fs, opt, descriptor) Then Return False
                     StreamGuard.RewindToStart(fs)
@@ -461,7 +463,7 @@ Namespace Global.Tomtastisch.FileClassifier
                 Dim descriptor As ArchiveDescriptor = Nothing
                 If Not ArchiveTypeResolver.TryDescribeBytes(data, opt, descriptor) Then Return False
                 If Not ArchiveSafetyGate.IsArchiveSafeBytes(data, opt, descriptor) Then Return False
-                Using ms As New System.IO.MemoryStream(data, writable:=False)
+                Using ms As New MemoryStream(data, writable:=False)
                     entries = ArchiveExtractor.TryExtractArchiveStreamToMemory(ms, opt, descriptor)
                     Return entries IsNot Nothing AndAlso entries.Count > 0
                 End Using
@@ -482,7 +484,7 @@ Namespace Global.Tomtastisch.FileClassifier
         End Property
 
         Public Function Process(
-                                stream As System.IO.Stream,
+                                stream As Stream,
                                 opt As FileTypeProjectOptions,
                                 depth As Integer,
                                 containerTypeValue As ArchiveContainerType,
@@ -584,7 +586,7 @@ Namespace Global.Tomtastisch.FileClassifier
                 Return True
             End If
 
-            Using nestedMs As New System.IO.MemoryStream(payload, writable:=False)
+            Using nestedMs As New MemoryStream(payload, writable:=False)
                 nestedResult = ArchiveProcessingEngine.ProcessArchiveStream(nestedMs, opt, depth + 1, nestedDescriptor,
                                                                             extractEntry)
             End Using
@@ -600,7 +602,7 @@ Namespace Global.Tomtastisch.FileClassifier
             Try
                 Using source = entry.OpenEntryStream()
                     If source Is Nothing OrElse Not source.CanRead Then Return False
-                    Using ms As New System.IO.MemoryStream()
+                    Using ms As New MemoryStream()
                         StreamBounds.CopyBounded(source, ms, maxBytes)
                         payload = ms.ToArray()
                         Return True
@@ -706,8 +708,8 @@ Namespace Global.Tomtastisch.FileClassifier
             End Get
         End Property
 
-        Public Function OpenStream() As System.IO.Stream Implements IArchiveEntryModel.OpenStream
-            If _entry Is Nothing Then Return System.IO.Stream.Null
+        Public Function OpenStream() As Stream Implements IArchiveEntryModel.OpenStream
+            If _entry Is Nothing Then Return Stream.Null
             Return _entry.OpenEntryStream()
         End Function
     End Class

src/FileTypeDetection/Infrastructure/ArchiveManagedInternals.vb

@@ -1,6 +1,9 @@
 Option Strict On
 Option Explicit On
 
+Imports System.IO
+Imports System.IO.Compression
+
 Namespace Global.Tomtastisch.FileClassifier
     ''' <summary>
     '''     Zentrale SSOT-Engine fuer archivbasierte Verarbeitung.
@@ -12,24 +15,24 @@ Namespace Global.Tomtastisch.FileClassifier
         Private Sub New()
         End Sub
 
-        Friend Shared Function ValidateArchiveStream(stream As System.IO.Stream, opt As FileTypeProjectOptions, depth As Integer) _
+        Friend Shared Function ValidateArchiveStream(stream As Stream, opt As FileTypeProjectOptions, depth As Integer) _
             As Boolean
             Return ProcessArchiveStream(stream, opt, depth, Nothing)
         End Function
 
         Friend Shared Function ProcessArchiveStream(
-                                                    stream As System.IO.Stream,
+                                                    stream As Stream,
                                                     opt As FileTypeProjectOptions,
                                                     depth As Integer,
-                                                    extractEntry As Func(Of System.IO.Compression.ZipArchiveEntry, Boolean)
+                                                    extractEntry As Func(Of ZipArchiveEntry, Boolean)
                                                     ) As Boolean
             If Not StreamGuard.IsReadable(stream) Then Return False
             If depth > opt.MaxZipNestingDepth Then Return False
 
             Try
                 StreamGuard.RewindToStart(stream)
 
-                Using zip As New System.IO.Compression.ZipArchive(stream, System.IO.Compression.ZipArchiveMode.Read, leaveOpen:=True)
+                Using zip As New ZipArchive(stream, ZipArchiveMode.Read, leaveOpen:=True)
                     If zip.Entries.Count > opt.MaxZipEntries Then Return False
 
                     Dim totalUncompressed As Long = 0
@@ -83,7 +86,7 @@ Namespace Global.Tomtastisch.FileClassifier
             End Try
         End Function
 
-        Private Shared Function IsNestedArchiveEntry(entry As System.IO.Compression.ZipArchiveEntry) As Boolean
+        Private Shared Function IsNestedArchiveEntry(entry As ZipArchiveEntry) As Boolean
             If entry Is Nothing Then Return False
 
             Try
@@ -116,7 +119,7 @@ Namespace Global.Tomtastisch.FileClassifier
         End Property
 
         Public Function Process(
-                                stream As System.IO.Stream,
+                                stream As Stream,
                                 opt As FileTypeProjectOptions,
                                 depth As Integer,
                                 containerTypeValue As ArchiveContainerType,
@@ -141,9 +144,9 @@ Namespace Global.Tomtastisch.FileClassifier
     Friend NotInheritable Class ArchiveManagedEntryModel
         Implements IArchiveEntryModel
 
-        Private ReadOnly _entry As System.IO.Compression.ZipArchiveEntry
+        Private ReadOnly _entry As ZipArchiveEntry
 
-        Friend Sub New(entry As System.IO.Compression.ZipArchiveEntry)
+        Friend Sub New(entry As ZipArchiveEntry)
             _entry = entry
         End Sub
 
@@ -182,8 +185,8 @@ Namespace Global.Tomtastisch.FileClassifier
             End Get
         End Property
 
-        Public Function OpenStream() As System.IO.Stream Implements IArchiveEntryModel.OpenStream
-            If _entry Is Nothing Then Return System.IO.Stream.Null
+        Public Function OpenStream() As Stream Implements IArchiveEntryModel.OpenStream
+            If _entry Is Nothing Then Return Stream.Null
             Return _entry.Open()
         End Function
     End Class