[Code Fix] Unsafe Whle Loop

[e6654321]

#10 - Unsafe loop condition which could lead to an error upon the Compute Phase

[nns2009]

But loop already has:

ifnot (cs.slice_refs()) {
  return ();
}

[e6654321]

But loop already has:

ifnot (cs.slice_refs()) {

  return ();

}

Yes I'm aware. The anti pattern I'm referring to is on doing 'true' inside the while loop. Putting loops without conditions should be avoided.

[nns2009]

Putting loops without conditions should be avoided

Why? Your suggestion just spends extra gas for the extra check, but doesn't affect logic in any way

[tolya-yanot]

no problems found