Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Global-exports to require React and support node modules #148

Open
wants to merge 1 commit into
base: gh-pages
Choose a base branch
from
Open

WIP: Global-exports to require React and support node modules #148

wants to merge 1 commit into from

Conversation

Deraen
Copy link

@Deraen Deraen commented Aug 18, 2017 •
edited
Loading

This is similar to reagent-project/reagent#306
https://github.com/reagent-project/reagent/blob/master/CHANGELOG.md#080-alpha1-2017-07-31

I'm opening PR's on other related projects also:

It is possible further changes to ClojureScript will make this change (partially) unnecessary: https://dev.clojure.org/jira/browse/CLJS-2331

Build causes lots of warnings:

WARNING: No such namespace: react, could not locate react.cljs, react.cljc, or JavaScript source providing "react" at line 12 /home/juho/Source/rum/test/rum/test/server_render.cljc
WARNING: Use of undeclared Var react/createElement at line 12 /home/juho/Source/rum/test/rum/test/server_render.cljc

Running lein cljsbuild once and opening index.html shows warnings on console:

image

This was referenced Aug 18, 2017
Closed
Open
Closed
@Deraen Deraen mentioned this pull request Aug 29, 2017
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Deraen