Skip to content

Commit 73b6d9c

Browse files
authored
Merge pull request #3330 from appirio-tech/revert-3316-issue-3211
Revert "Avoid reloading file icons in the Assets Library #3211"
2 parents 3b1b1f5 + 7146031 commit 73b6d9c

File tree

3 files changed

+18
-242
lines changed

3 files changed

+18
-242
lines changed

src/components/AssetsLibrary/FilesGridView.jsx

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@ import DeleteFileLinkModal from '../LinksMenu/DeleteFileLinkModal'
1010
import EditFileAttachment from '../LinksMenu/EditFileAttachment'
1111
import SubFolder from './SubFolder'
1212
import ItemOperations from './ItemOperations'
13-
import FileIcon from '../../components/FileIcon'
1413

1514
import FolderIcon from '../../assets/icons/v.2.5/icon-folder-small.svg'
1615

@@ -150,10 +149,16 @@ const FilesGridView = ({
150149
/>
151150
</li>)
152151
} else {
152+
let iconPath
153+
try {
154+
iconPath = require('../../assets/icons/' + link.title.split('.')[1] +'.svg')
155+
} catch(err) {
156+
iconPath = require('../../assets/icons/default.svg')
157+
}
153158
return (
154159
<li styleName="assets-gridview-row" key={'assets-gridview-item-' +idx}>
155160
<div styleName="flex-item item-type">
156-
<FileIcon type={link.title.split('.')[1]} />
161+
<img width={42} height={42} src={iconPath} />
157162
</div>
158163
<div styleName="flex-item item-name"><p>{renderLink(link)}</p></div>
159164
<div styleName="flex-item item-modified">{formatModifyDate(link)}</div>

src/components/AssetsLibrary/SubFolder.jsx

Lines changed: 11 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@ import cn from 'classnames'
55
import DeleteFileLinkModal from '../LinksMenu/DeleteFileLinkModal'
66
import ItemOperations from './ItemOperations'
77
import FolderIcon from '../../assets/icons/v.2.5/icon-folder-small.svg'
8-
import FileIcon from '../../components/FileIcon'
98

109
import './GridView.scss'
1110
class SubFolder extends React.Component {
@@ -87,17 +86,19 @@ class SubFolder extends React.Component {
8786
</li>
8887
)
8988
}
90-
let iconKey
91-
if (isLinkSubFolder) {
92-
// Key Icon here
93-
iconKey = 'link-12'
94-
} else {
95-
iconKey = childLink.title.split('.')[1]
89+
let iconPath
90+
try {
91+
if (isLinkSubFolder) {
92+
//Link Icon here
93+
iconPath = require('../../assets/icons/link-12.svg')
94+
} else {
95+
iconPath = require('../../assets/icons/' + childLink.title.split('.')[1] +'.svg')
96+
}
97+
} catch(err) {
98+
iconPath = require('../../assets/icons/default.svg')
9699
}
97100
return (<li styleName="assets-gridview-row" key={`childlink-${childLink.address}-${i}`}>
98-
<div styleName="flex-item item-type">
99-
<FileIcon type={iconKey} />
100-
</div>
101+
<div styleName="flex-item item-type"><img width={42} height={42} src={ iconPath } /></div>
101102
<div styleName="flex-item item-name"><p>{renderLink(childLink)}</p></div>
102103
<div styleName="flex-item item-modified">{formatModifyDate(childLink)}</div>
103104
<div styleName="flex-item item-action">

src/components/FileIcon.jsx

Lines changed: 0 additions & 230 deletions
This file was deleted.

0 commit comments

Comments
 (0)