Skip to content

Commit a1d392c

Browse files
authored
Merge pull request #2825 from appirio-tech/hotfix/avatars-with-email-master
Hotfix/avatars with email master
2 parents 9be92e9 + ace8c3c commit a1d392c

File tree

3 files changed

+36
-25
lines changed

3 files changed

+36
-25
lines changed

src/components/TeamManagement/ProjectManagementDialog.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -153,7 +153,7 @@ class Dialog extends React.Component {
153153
className={`project-member-layout ${(i%2 !== 0) ? 'dark' : ''}`}
154154
>
155155
<Avatar
156-
userName={invite.email}
156+
userName={invite.email || userFullName}
157157
avatarUrl={invite.email ? '' : getAvatarResized(_.get(invite.member || {}, 'photoURL'), 40)}
158158
size={40}
159159
/>

src/components/TeamManagement/TeamManagement.jsx

Lines changed: 22 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -92,13 +92,19 @@ class TeamManagement extends React.Component {
9292
<UserTooltip usr={member} id={i} key={i} previewAvatar size={40} />
9393
)
9494
})}
95-
{projectTeamInvites.map((member, i) => {
96-
const wrapMember = {
97-
...member,
98-
...member.member
99-
}
95+
{projectTeamInvites.map((invite, i) => {
96+
const member = invite.email ? { email: invite.email } : invite.member
97+
10098
return (
101-
<UserTooltip usr={wrapMember} id={i} key={i} previewAvatar size={40} invitedLabel teamInvites />
99+
<UserTooltip
100+
usr={member}
101+
id={i}
102+
key={i}
103+
previewAvatar
104+
size={40}
105+
invitedLabel
106+
showEmailOnly={!!invite.email}
107+
/>
102108
)
103109
})}
104110
{ (canShowInvite) &&
@@ -127,16 +133,19 @@ class TeamManagement extends React.Component {
127133
<UserTooltip usr={member} id={i} key={i} previewAvatar size={40} />
128134
)
129135
})}
130-
{topcoderTeamInvites.map((member, i) => {
131-
if (member.isCustomer) {
136+
{topcoderTeamInvites.map((invite, i) => {
137+
if (invite.isCustomer) {
132138
return
133139
}
134-
const wrapMember = {
135-
...member,
136-
...member.member
137-
}
138140
return (
139-
<UserTooltip usr={wrapMember} id={i} key={i} previewAvatar size={40} invitedLabel />
141+
<UserTooltip
142+
usr={invite.member}
143+
id={i}
144+
key={i}
145+
previewAvatar
146+
size={40}
147+
invitedLabel
148+
/>
140149
)
141150
})}
142151
{ (canJoinAsCopilot || canJoinAsManager) &&

src/components/User/UserTooltip.jsx

Lines changed: 13 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ import IconDirectArrow from '../../assets/icons/icon-direct-arrow.svg'
99

1010
require('./UserTooltip.scss')
1111

12-
const UserTooltip = ({ usr, id, previewAvatar, size, invitedLabel, teamInvites }) => {
12+
const UserTooltip = ({ usr, id, previewAvatar, size, invitedLabel, showEmailOnly }) => {
1313
const theme = `customer-data size-${size}`
1414
const tooltipMargin = previewAvatar ? -(100 + (id * 20)) : 0
1515
const userHandle = _.get(usr, 'handle')
@@ -18,10 +18,11 @@ const UserTooltip = ({ usr, id, previewAvatar, size, invitedLabel, teamInvites }
1818
const lastName = _.get(usr, 'lastName', '')
1919
let userFullName = `${firstName} ${lastName}`
2020
userFullName = userFullName.trim().length > 0 ? userFullName : 'Connect user'
21-
const avatar =
21+
const avatar =
2222
(
23-
<Avatar avatarUrl={userEmail ? '' : getAvatarResized(_.get(usr || {}, 'photoURL'), 40)}
24-
userName={userEmail}
23+
<Avatar
24+
avatarUrl={showEmailOnly ? '' : getAvatarResized(_.get(usr || {}, 'photoURL'), 40)}
25+
userName={showEmailOnly ? userEmail : userFullName}
2526
/>
2627
)
2728
return (
@@ -30,8 +31,8 @@ const UserTooltip = ({ usr, id, previewAvatar, size, invitedLabel, teamInvites }
3031
{
3132
previewAvatar ? (<div className={`stack-avatar-${id}`}>
3233
<Avatar
33-
avatarUrl={userEmail ? '' : getAvatarResized(_.get(usr || {}, 'photoURL'), 40)}
34-
userName={userEmail}
34+
avatarUrl={showEmailOnly ? '' : getAvatarResized(_.get(usr || {}, 'photoURL'), 40)}
35+
userName={showEmailOnly ? userEmail : userFullName}
3536
size={size}
3637
/>
3738
{invitedLabel && <IconDirectArrow className="direct-arrow"/>}
@@ -42,7 +43,7 @@ const UserTooltip = ({ usr, id, previewAvatar, size, invitedLabel, teamInvites }
4243
<div className="tooltip-body">
4344
<div className="top-container">
4445
<div className="tt-col-avatar">
45-
{ !userEmail ? (
46+
{ !showEmailOnly ? (
4647
<a href={`//www.${DOMAIN}/members/${userHandle}/`} target="_blank" rel="noopener noreferrer" className="tt-user-avatar">
4748
{avatar}
4849
</a>
@@ -53,13 +54,13 @@ const UserTooltip = ({ usr, id, previewAvatar, size, invitedLabel, teamInvites }
5354
)}
5455
</div>
5556
<div className="tt-col-user-data">
56-
{!userEmail && <div className="user-name-container">
57+
{!showEmailOnly && <div className="user-name-container">
5758
<span>{userFullName}</span>
5859
</div>}
59-
{!userEmail && <div className="user-handle-container">
60+
{!showEmailOnly && <div className="user-handle-container">
6061
<span>{userHandle}</span>
6162
</div>}
62-
{userEmail && <div className={`user-email-container ${teamInvites ? 'text-dark' : ''}`}>
63+
{userEmail && <div className={`user-email-container ${showEmailOnly ? 'text-dark' : ''}`}>
6364
<a href={`mailto:${userEmail}`}>{userEmail}</a>
6465
</div>}
6566
{invitedLabel && <div className="invited-label">invited</div>}
@@ -82,7 +83,8 @@ UserTooltip.propTypes = {
8283

8384
UserTooltip.defaultProps = {
8485
size: 30,
85-
previewAvatar: false
86+
previewAvatar: false,
87+
showEmailOnly: false,
8688
}
8789

8890
export default UserTooltip

0 commit comments

Comments
 (0)