Merge pull request #6863 from topcoder-platform/develop

Release v1.21.12 - Challenge with registration phase open is showing with status `Challenge is currently on hold`

Author: luizrrodrigues

src/shared/components/challenge-detail/Header/index.jsx

@@ -18,6 +18,7 @@ import { COMPETITION_TRACKS } from 'utils/tc';
 import { phaseEndDate } from 'utils/challenge-listing/helper';
 import {
   getTimeLeft,
+  isRegistrationPhase,
 } from 'utils/challenge-detail/helper';
 
 import LeftArrow from 'assets/images/arrow-prev.svg';
@@ -112,9 +113,12 @@ export default function ChallengeHeader(props) {
     registrationEnded = !regPhase.isOpen;
   }
 
-  const currentPhases = challenge.phases
-    .filter(p => p.name !== 'Registration' && p.isOpen)
-    .sort((a, b) => moment(a.scheduledEndDate).diff(b.scheduledEndDate))[0];
+  const allOpenPhases = challenge.phases
+    .filter(p => p.isOpen)
+    .sort((a, b) => moment(a.scheduledEndDate).diff(b.scheduledEndDate));
+
+  const currentPhases = allOpenPhases
+    .filter(p => !isRegistrationPhase(p))[0];
 
   const trackLower = track ? track.replace(' ', '-').toLowerCase() : 'design';
 
@@ -138,14 +142,14 @@ export default function ChallengeHeader(props) {
 
   const openPhases = sortedAllPhases.filter(p => p.isOpen);
   let nextPhase = openPhases[0];
-  if (hasRegistered && openPhases[0] && openPhases[0].name === 'Registration') {
+  if (hasRegistered && openPhases[0] && isRegistrationPhase(openPhases[0])) {
     nextPhase = openPhases[1] || {};
   }
 
   const deadlineEnd = moment(nextPhase && phaseEndDate(nextPhase));
   const currentTime = moment();
 
-  const timeDiff = getTimeLeft(currentPhases, 'to go', true);
+  const timeDiff = getTimeLeft(currentPhases || allOpenPhases[0], 'to go', true);
 
   if (!timeDiff.late) {
     timeDiff.text = timeDiff.text.replace('to go', '');

src/shared/utils/challenge-detail/helper.jsx

@@ -47,6 +47,10 @@ export function getEndDate(challenge) {
   return moment(endPhaseDate).format('MMM DD');
 }
 
+export function isRegistrationPhase(phase) {
+  return phase.name === 'Registration';
+}
+
 /**
  * Generates human-readable string containing time till the phase end.
  * @param {Object} phase phase need to check
@@ -58,11 +62,13 @@ export function getTimeLeft(
   fullText = false,
 ) {
   const STALLED_TIME_LEFT_MSG = 'Challenge is currently on hold';
+  const REGISTRATION_PHASE_MESSAGE = 'Open For Registration';
   const FF_TIME_LEFT_MSG = 'Winner is working on fixes';
   const HOUR_MS = 60 * 60 * 1000;
   const DAY_MS = 24 * HOUR_MS;
 
   if (!phase) return { late: false, text: STALLED_TIME_LEFT_MSG };
+  if (isRegistrationPhase(phase)) return { late: false, text: REGISTRATION_PHASE_MESSAGE };
   if (phase.phaseType === 'Final Fix') {
     return { late: false, text: FF_TIME_LEFT_MSG };
   }