Skip to content

Commit 40b2018

Browse files
committed
Fix for editing TG task iterative review
1 parent 52c1685 commit 40b2018

File tree

1 file changed

+10
-2
lines changed

1 file changed

+10
-2
lines changed

src/apps/review/src/pages/active-review-assignements/ScorecardDetailsPage/ScorecardDetailsPage.tsx

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -159,7 +159,11 @@ const PHASE_ROLE_MATCHERS: Partial<Record<ReviewPhaseType, RoleMatcher>> = {
159159
'checkpoint review': normalizedRoleName => normalizedRoleName === 'checkpointreviewer',
160160
'checkpoint screening': normalizedRoleName => normalizedRoleName === 'checkpointscreener',
161161
'post-mortem': normalizedRoleName => normalizedRoleName.includes('postmortem'),
162-
review: normalizedRoleName => normalizedRoleName === 'reviewer',
162+
review: normalizedRoleName => (
163+
normalizedRoleName.includes('reviewer')
164+
&& !normalizedRoleName.includes('checkpoint')
165+
&& !normalizedRoleName.includes('postmortem')
166+
),
163167
screening: normalizedRoleName => (
164168
(
165169
normalizedRoleName.includes('screener')
@@ -228,7 +232,11 @@ const canRoleEditPhase = (
228232
currentPhaseReviewType: ReviewPhaseType | undefined,
229233
normalizedRoleName: string,
230234
): boolean => {
231-
if (!reviewPhaseType || currentPhaseReviewType !== reviewPhaseType) {
235+
if (!reviewPhaseType) {
236+
return false
237+
}
238+
239+
if (currentPhaseReviewType && currentPhaseReviewType !== reviewPhaseType) {
232240
return false
233241
}
234242

0 commit comments

Comments
 (0)