Lint fixes

Author: jmgasper

src/apps/admin/src/lib/components/DefaultReviewersAddForm/DefaultReviewersAddForm.tsx

@@ -148,7 +148,10 @@ export const DefaultReviewersAddForm: FC<Props> = (props: Props) => {
 
     const onSubmit = useCallback(
         (data: FormAddDefaultReviewer) => {
-            const requestBody = _.pickBy(data, _.identity)
+            const requestBody = _.omitBy(
+                data,
+                value => value === undefined || value === null || value === '',
+            )
             if (isEdit) {
                 doUpdateDefaultReviewer(requestBody, () => {
                     navigate('./../..')

src/apps/review/src/pages/scorecards/EditScorecardPage/components/BasicSelect.tsx

@@ -1,19 +1,29 @@
 import { forwardRef, SelectHTMLAttributes } from 'react'
 import classNames from 'classnames'
 
-interface BasicSelectProps<T> extends SelectHTMLAttributes<T> {
-    options: { label: string; value: string|boolean|number }[];
-    mapValue?: (value: any) => string;
+interface BasicSelectProps extends SelectHTMLAttributes<HTMLSelectElement> {
+    options: { label: string; value: string | boolean | number }[];
+    mapValue?: (value: string | number | boolean | '') => string;
     placeholder?: string;
 }
 
-const BasicSelect = forwardRef<HTMLSelectElement, BasicSelectProps<any>>((
-    props,
+const BasicSelect = forwardRef<HTMLSelectElement, BasicSelectProps>((
+    props: BasicSelectProps,
     ref,
 ) => {
-    const { className, options, placeholder, value, mapValue: _mapValue, ...rest } = props
+    const {
+        className,
+        options,
+        placeholder,
+        value,
+        mapValue,
+        ...rest
+    }: BasicSelectProps = props
 
-    const normalizedValue = value === null || value === undefined ? '' : value
+    const normalizedValue = value === null || value === undefined ? '' : String(value)
+    const displayValue = typeof mapValue === 'function'
+        ? mapValue(normalizedValue)
+        : normalizedValue
 
     return (
         <select
@@ -25,7 +35,7 @@ const BasicSelect = forwardRef<HTMLSelectElement, BasicSelectProps<any>>((
                     !normalizedValue && `${normalizedValue}` !== 'false' && 'empty',
                 )
             }
-            value={normalizedValue as any}
+            value={displayValue}
         >
             <option
                 key='placeholder-option'
@@ -34,10 +44,10 @@ const BasicSelect = forwardRef<HTMLSelectElement, BasicSelectProps<any>>((
             >
                 {placeholder}
             </option>
-            {options.map((option, index) => (
+            {options.map(option => (
                 <option
-                    key={`${option.value ?? option.label ?? index}-${index}`}
-                    value={`${option.value ?? ''}`}
+                    key={String(option.value ?? option.label)}
+                    value={String(option.value ?? '')}
                 >
                     {option.label}
                 </option>

src/apps/review/src/pages/scorecards/EditScorecardPage/components/ScorecardInfoForm.tsx

@@ -70,10 +70,10 @@ const toChallengeTrackLabel = (value: string): string => (
 )
 
 const legacyChallengeTrackMap: Record<string, string> = {
-    DEVELOPMENT: 'DEVELOPMENT',
     DEVELOP: 'DEVELOPMENT',
-    QUALITY_ASSURANCE: 'QUALITY_ASSURANCE',
+    DEVELOPMENT: 'DEVELOPMENT',
     QA: 'QUALITY_ASSURANCE',
+    QUALITY_ASSURANCE: 'QUALITY_ASSURANCE',
 }
 
 const normalizeTrackOptionValue = (track: useFetchChallengeTracksProps['challengeTracks'][number]): string => {
@@ -140,15 +140,16 @@ const ScorecardInfoForm: FC = () => {
     const form = useFormContext()
     const { challengeTracks }: useFetchChallengeTracksProps = useFetchChallengeTracks()
     const { challengeTypes }: useFetchChallengeTypesProps = useFetchChallengeTypes()
-    const { getValues, setValue } = form
+    const { getValues, setValue }: Pick<typeof form, 'getValues' | 'setValue'> = form
     const normalizeValue = useCallback((
         value: string | number | boolean | null | undefined,
     ): string | undefined => {
         if (value === null || value === undefined) {
             return undefined
         }
 
-        const normalized = String(value).trim()
+        const normalized = String(value)
+            .trim()
 
         return normalized.length ? normalized : undefined
     }, [])

src/apps/review/src/pages/scorecards/EditScorecardPage/components/ScorecardQuestionForm.tsx

@@ -172,17 +172,20 @@ const ScorecardQuestionForm: FC<ScorecardQuestionFormProps> = (props: ScorecardQ
                                             <BasicSelect
                                                 options={scorecardScaleOptions}
                                                 {...{
-                                                    mapValue: (value: string) => (
-                                                        `${value?.toLowerCase()}${
-                                                            value === 'SCALE'
+                                                    mapValue: (value: string | number | boolean | '') => {
+                                                        const stringValue = typeof value === 'string'
+                                                            ? value
+                                                            : String(value ?? '')
+                                                        return `${stringValue.toLowerCase()}${
+                                                            stringValue === 'SCALE'
                                                                 ? `(${
                                                                     get(values, `${name}.${index}.scaleMin`)
                                                                 }-${
                                                                     get(values, `${name}.${index}.scaleMax`)
                                                                 })`
                                                                 : ''
                                                         }`
-                                                    ),
+                                                    },
                                                     onChange: ((
                                                         ev: ChangeEvent<HTMLInputElement>,
                                                         field: any,