Merge pull request #3 from topcoder-platform/fix/member-role-validation

Fix member role validation, remove credentials from .env.sample

Author: jmgasper

.env.sample

@@ -14,12 +14,12 @@ AUTH0_AUDIENCE="http://localhost:4000"
 AUTH0_CLIENT_ID="abc123"
 AUTH0_CLIENT_SECRET="secret"
 
-M2M_AUTH_URL="https://topcoder-dev.auth0.com/oauth/token"
-M2M_AUTH_CLIENT_ID="jGIf2pd3f44B1jqvOai30BIKTZanYBfU"
-M2M_AUTH_CLIENT_SECRET="ldzqVaVEbqhwjM5KtZ79sG8djZpAVK8Z7qieVcC3vRjI4NirgcinKSBpPwk6mYYP"
-M2M_AUTH_DOMAIN="topcoder-dev.auth0.com"
-M2M_AUTH_AUDIENCE="https://m2m.topcoder-dev.com/"
-M2M_AUTH_PROXY_SEREVR_URL="https://auth0proxy.topcoder-dev.com/token"
+M2M_AUTH_URL="Your-auth-url"
+M2M_AUTH_CLIENT_ID="Your-cient-id"
+M2M_AUTH_CLIENT_SECRET="Your-client-secret"
+M2M_AUTH_DOMAIN="Your-auth-domain"
+M2M_AUTH_AUDIENCE="Your-auth-audience"
+M2M_AUTH_PROXY_SEREVR_URL="Your-server-url"
 
 BUSAPI_URL="http://localhost:4000/eventBus"
 

src/api/projectMember/project-member.dto.ts

@@ -1,6 +1,5 @@
 import { ApiProperty, ApiPropertyOptional } from '@nestjs/swagger';
 import {
-  IsEnum,
   IsIn,
   IsNotEmpty,
   IsNumber,
@@ -26,17 +25,8 @@ const allowedUpdateRoles = [
   PROJECT_MEMBER_ROLE.PROJECT_MANAGER,
 ];
 
-enum ProjectMemberRole {
-  MANAGER = 'manager',
-  OBSERVER = 'observer',
-  CUSTOMER = 'customer',
-  COPILOT = 'copilot',
-  ACCOUNT_MANAGER = 'account_manager',
-  PROGRAM_MANAGER = 'program_manager',
-  ACCOUNT_EXECUTIVE = 'account_executive',
-  SOLUTION_ARCHITECT = 'solution_architect',
-  PROJECT_MANAGER = 'project_manager',
-}
+// Use PROJECT_MEMBER_ROLE values directly instead of duplicating enum
+const ProjectMemberRoleValues = Object.values(PROJECT_MEMBER_ROLE);
 
 export class CreateProjectMemberDto {
   @ApiPropertyOptional({
@@ -51,11 +41,12 @@ export class CreateProjectMemberDto {
 
   @ApiProperty({
     name: 'role',
-    enum: ProjectMemberRole,
+    enum: ProjectMemberRoleValues,
   })
-  @IsEnum(ProjectMemberRole)
+  @IsString()
+  @IsIn(ProjectMemberRoleValues)
   @IsOptional()
-  role?: ProjectMemberRole;
+  role?: string;
 }
 
 export class UpdateProjectMemberDto {
@@ -200,11 +191,12 @@ export class ProjectMemberResponseDto {
 export class QueryProjectMemberDto {
   @ApiProperty({
     description: 'project member role',
-    enum: ProjectMemberRole,
+    enum: ProjectMemberRoleValues,
   })
-  @IsEnum(ProjectMemberRole)
+  @IsString()
+  @IsIn(ProjectMemberRoleValues)
   @IsOptional()
-  role?: ProjectMemberRole;
+  role?: string;
 
   @ApiProperty({
     name: 'fields',

src/main.ts

@@ -39,8 +39,8 @@ async function bootstrap() {
   // Add swagger docs module
   const config = new DocumentBuilder()
     .setTitle('Projects API')
-    .setDescription('TopCoder Projects API v5 Document')
-    .setVersion('v5')
+    .setDescription('TopCoder Projects API v6 Document')
+    .setVersion('v6')
     .addBearerAuth({
       type: 'http',
       scheme: 'bearer',
@@ -51,7 +51,7 @@ async function bootstrap() {
     })
     .build();
   const document = SwaggerModule.createDocument(app, config);
-  SwaggerModule.setup('/api-docs', app, document);
+  SwaggerModule.setup(`${AppConfig.prefix}/projects/api-docs`, app, document);
 
   await app.listen(AppConfig.port);
 }