add maintenance banner #380
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -0,0 +1,43 @@ | |||
| @import 'lib/styles/fonts.scss'; | |||
There was a problem hiding this comment.
[maintainability]
Consider using a relative import path for fonts.scss to ensure compatibility across different environments and avoid potential issues with module resolution.
| .bannerText { | ||
| white-space: pre-wrap; | ||
| overflow-wrap: break-word; | ||
| font-family: $roboto; |
There was a problem hiding this comment.
[❗❗ correctness]
Ensure $roboto is defined in fonts.scss. If not, this could lead to a compilation error or unexpected font rendering.
| <div class={styles.banner}> | ||
| <div class={styles.bannerContent}> | ||
| <div class={styles.bannerText}> | ||
| Topcoder will be undergoing maintenance on Tuesday, October 21, 2025 from 1 AM to 6 AM EST |
There was a problem hiding this comment.
[maintainability]
Consider externalizing the maintenance message to a configuration file or environment variable to allow for easier updates without code changes.
|
|
||
| <div class="tc-universal-nav-wrap"> | ||
| <!-- <Banner /> --> | ||
| <Maintenance /> |
There was a problem hiding this comment.
[design]
Consider verifying that the Maintenance component is conditionally rendered based on a relevant state or prop. Rendering it unconditionally might not be appropriate if maintenance mode is not always active.
| onMount(checkAndLoadFonts) | ||
| </script> | ||
|
|
||
| <Maintenance /> |
There was a problem hiding this comment.
[design]
Consider verifying that the <Maintenance /> component does not interfere with the layout or functionality of the existing navigation elements. Ensure it is appropriately styled and positioned, especially on different screen sizes.
No description provided.