Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Multiple Browsers #167

Open
mattthaber opened this issue Aug 7, 2020 · 1 comment
Open

Support Multiple Browsers #167

mattthaber opened this issue Aug 7, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@mattthaber
Copy link
Contributor

Firefox is supported in puppeteer now, would be nice to support multiple browsers that could be configured via ENV variables potentially?

@noahnu
Copy link
Contributor

noahnu commented Aug 1, 2022

Rather than an env var, we could pass the browser as a config option. There's the question of whether we should have 2 lambda functions, one per browser, to keep the size of the docker image down. In this case, we pass a map of browser/env to lambda functions so a single yarn sanity-runner-client execution could use different lambda functions per test.

@noahnu noahnu added the enhancement New feature or request label Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants