Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract 3rd Party Integrations into plugin system #293

Open
noahnu opened this issue Jun 16, 2022 · 1 comment
Open

Extract 3rd Party Integrations into plugin system #293

noahnu opened this issue Jun 16, 2022 · 1 comment

Comments

@noahnu
Copy link
Contributor

noahnu commented Jun 16, 2022

Is your feature request related to a problem? Please describe.

Fullstory, datadog, slack, pagerduty are all baked into the code. This makes sanity-runner very specific to Top Hat's tech stack. We should build a plugin system so these integrations are optional add-ons.

Describe the solution you'd like
A clear and concise description of what you want to happen.

A plugin system similar to how we do it in monodeploy (e.g. tappable). Fullstory/datadog etc can be first-party plugins we maintain in the sanity-runner monorepo.

@noahnu noahnu self-assigned this Jul 1, 2022
@noahnu
Copy link
Contributor Author

noahnu commented Aug 1, 2022

I've pulled out the 3rd party integrations into "plugins", however they're still hardcoded in the service at the moment.

TODO:

  • Support dynamic loading of plugins.
  • Move reporting plugins from service to client? Create both service and client plugins.

Unanswered questions:

  • How do plugins interact with each other?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant