Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Development version is lower than released version #123

Open
jorti opened this issue Jun 28, 2022 · 8 comments
Open

Development version is lower than released version #123

jorti opened this issue Jun 28, 2022 · 8 comments

Comments

@jorti
Copy link

jorti commented Jun 28, 2022

I've published latest git commit in Fedora rawhide to pick the fixes related to Python 3.11, however I've discovered that the development version 1.8.0-dev is considered lower than 1.8.0, causing dependency problems on other packages that require stem >= 1.8.0, see the Fedora bug: https://bugzilla.redhat.com/show_bug.cgi?id=2101749

The version was changed in commit 4fd458d

The development releases are ordered before the final release, see:

https://peps.python.org/pep-0440/#developmental-releases

Please, consider updating the version to 1.8.1-dev or similar.
Thank you.

@atagar
Copy link
Contributor

atagar commented Jun 28, 2022

Hi Juan. Stem 1.8.0 is the latest release and I don't have any plans on making future ones. That said, if Stem development resumes I'd be happy to adjust how we tag between releases.

@jorti
Copy link
Author

jorti commented Jun 29, 2022

Hi, the problem with the current dev version is that it has jumped backwards. Maybe using something like 1.8.0-post-dev ?

If this isn't fixed, I'll need to patch the version number downstream.
Thanks.

@jorti
Copy link
Author

jorti commented Jun 29, 2022

Well, it turns out that 1.8.0-post-dev is not ordered after 1.8.0-dev as I was expecting.

I'm patching the version to 1.8.1-dev downstream to fix the dependency problem.

@kloczek
Copy link

kloczek commented Jun 30, 2022

@atagar what about fliush alredy commited changes as new release? 🤔
1.8.0...master

@atagar
Copy link
Contributor

atagar commented Jun 30, 2022

Stem's master branch is far from a stable state for a release. At the very least #77 would need to be addressed.

@emdee-is
Copy link

In stem/init.py it says

__version__ = '1.8.0-dev'

The latest version shipping with gentoo and debian is 1.8.2

Please bump this ASAP to at least 1.8.3 so that we can make use of the git repo.

@atagar
Copy link
Contributor

atagar commented Feb 20, 2024

Again, you seem to be referencing the master branch. Do NOT package that for Gentoo. If the version has a '-dev' suffix then you're using the wrong thing. ;)

@emdee-is
Copy link

emdee-is commented Feb 21, 2024

Ooops - nice to know. Could you put a note on this in the README? I thought master on github was expected to be the current branch unless noted in the README. There are a lot of differennces on maint so now the maint->gitlab differences are a big divergence.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants