Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Descriptor validate() method #90

Open
atagar opened this issue Feb 20, 2021 · 0 comments
Open

Add Descriptor validate() method #90

atagar opened this issue Feb 20, 2021 · 0 comments

Comments

@atagar
Copy link
Contributor

atagar commented Feb 20, 2021

Our Descriptor class' construction and validation are coupled together, which complicates validation of individual descriptors (rather than whole files) as discussed on BridgeDB ticket 40006.

Stem evolved this way for performance. When read without validation we can lazily load content (parsing attributes on demand), whereas validation requires us to process the whole document up front.

We should move checks into a validate() method so all descriptors can be checked regardless of how they were constructed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant