Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: Support unmount by going back the browser #100

Open
thyeone opened this issue Dec 19, 2024 · 0 comments
Open

Suggestion: Support unmount by going back the browser #100

thyeone opened this issue Dec 19, 2024 · 0 comments

Comments

@thyeone
Copy link

thyeone commented Dec 19, 2024

Hello. first of all, thank you for the great library :) No other than that, I have a simple suggestion.

When I use overlay in a web view environment, I want it to be compatible with going backwards in the browser and going backwards in Android.

So the way I tried to solve it, by adding browser history when the overlay is mounted on OverlayController in the previous version of the overlay-kit, @toss/useoverlay source code.

However, I had the following limitations.

  • If there are components within the overlay that call useOverlay hook, there will be more than one stack of history. (It should work that one stack is stacked).
  • This is a Native part and may not be relevant to the library, and it's awkwardly unmountable when swipe the screen in iOS and remove the history.

I wonder if these parts can be improved and if there are any plans to support.

Thank you !

@thyeone thyeone changed the title Support unmount by go back the browser Suggestion: Support unmount by go back the browser Dec 19, 2024
@thyeone thyeone changed the title Suggestion: Support unmount by go back the browser Suggestion: Support unmount by going back the browser Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant