Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: peerDependency error of @suspensive/react when using @suspensive/react-query standalone #1349

Open
kangju2000 opened this issue Nov 5, 2024 · 2 comments
Assignees
Labels
bug Something isn't working question Further information is requested

Comments

@kangju2000
Copy link
Collaborator

Package Scope

@suspensive/react, @suspensive/react-query, @suspensive/react-query-4, @suspensive/react-query-5

Bug description

When using @suspensive/react-query as standalone, I'm getting a peerDependency error for @suspensive/react.

Failed to compile.

../../node_modules/.pnpm/@[email protected]_@[email protected][email protected]/node_modules/@suspensive/react-query-5/dist/chunk-AT3YTYWU.js
Module not found: Can't resolve '@suspensive/react'

https://nextjs.org/docs/messages/module-not-found

Import trace for requested module:
../../node_modules/.pnpm/@[email protected]_@[email protected][email protected]/node_modules/@suspensive/react-query-5/dist/index.js
../../node_modules/.pnpm/@[email protected]_@[email protected][email protected]/node_modules/@suspensive/react-query/dist/index.js
./app/clubs/[id]/page.tsx
  • Node.js: 20.10.0
  • Next.js: 14
  • @tanstack/react-query: 5
  • @suspensive/react-query: 2.18.4

Expected behavior

According to the official documentation, we should only need to install:

npm install @suspensive/react-query @tanstack/react-query

To Reproduce

https://codesandbox.io/p/sandbox/optimistic-wood-c4jp33

image

Possible Solution

No response

etc.

Is this intended behavior? It seems we might need to address this gap in one of two ways:

  1. Documentation could be updated to include @suspensive/react installation:
    npm install @suspensive/react-query @suspensive/react @tanstack/react-query
    
  2. Or the peerDependency configuration could be adjusted to align with the current documentation
@kangju2000 kangju2000 added the question Further information is requested label Nov 5, 2024
Copy link

coauthors bot commented Nov 5, 2024

People can be co-author:

Candidate Reasons Count Add this as commit message
@kangju2000 #1349 1 Co-authored-by: kangju2000 <[email protected]>
@manudeli #1349 (comment) 1 Co-authored-by: manudeli <[email protected]>

@manudeli
Copy link
Member

manudeli commented Nov 5, 2024

#1325

Same issue in my opinion

@kangju2000 kangju2000 added the bug Something isn't working label Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants