From 660f92e3bd9aa4eddf638610cfdb5b7ca4f15c94 Mon Sep 17 00:00:00 2001 From: Touhidur Rahman Date: Thu, 22 Aug 2024 18:03:07 +0600 Subject: [PATCH] pkp/pkp-lib#10214 fixed review round outstanding status determining process --- jobs/email/EditorialReminder.php | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/jobs/email/EditorialReminder.php b/jobs/email/EditorialReminder.php index fca40c30c7d..90fb0f1c656 100644 --- a/jobs/email/EditorialReminder.php +++ b/jobs/email/EditorialReminder.php @@ -92,22 +92,22 @@ public function handle(): void $reviewRoundDao = DAORegistry::getDAO('ReviewRoundDAO'); $reviewRound = $reviewRoundDao->getLastReviewRoundBySubmissionId($submission->getId(), $submission->getData('stageId')); - if ($reviewRound->getStatus() === ReviewRound::REVIEW_ROUND_STATUS_PENDING_REVIEWERS) { + if ($reviewRound->determineStatus() === ReviewRound::REVIEW_ROUND_STATUS_PENDING_REVIEWERS) { $outstanding[$submissionId] = __('editor.submission.roundStatus.pendingReviewers'); continue; } - if ($reviewRound->getStatus() === ReviewRound::REVIEW_ROUND_STATUS_REVIEWS_COMPLETED) { + if ($reviewRound->determineStatus() === ReviewRound::REVIEW_ROUND_STATUS_REVIEWS_COMPLETED) { $outstanding[$submissionId] = __('editor.submission.roundStatus.reviewsCompleted'); continue; } - if ($reviewRound->getStatus() === ReviewRound::REVIEW_ROUND_STATUS_REVIEWS_OVERDUE) { + if ($reviewRound->determineStatus() === ReviewRound::REVIEW_ROUND_STATUS_REVIEWS_OVERDUE) { $outstanding[$submissionId] = __('editor.submission.roundStatus.reviewOverdue'); continue; } - if ($reviewRound->getStatus() === ReviewRound::REVIEW_ROUND_STATUS_REVISIONS_SUBMITTED) { + if ($reviewRound->determineStatus() === ReviewRound::REVIEW_ROUND_STATUS_REVISIONS_SUBMITTED) { $outstanding[$submissionId] = __('editor.submission.roundStatus.revisionsSubmitted'); continue; }