From 526e551e8027fcac0e8dc02aac5e09f078aff14f Mon Sep 17 00:00:00 2001 From: Tomi Parviainen Date: Sat, 27 Jan 2024 18:02:42 +0200 Subject: [PATCH] Refactor integration tests --- src/ClashOfClans.Tests.Integration/ClansTests.cs | 4 ++-- src/ClashOfClans.Tests.Integration/DumpExtensions.cs | 5 +++-- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/src/ClashOfClans.Tests.Integration/ClansTests.cs b/src/ClashOfClans.Tests.Integration/ClansTests.cs index a80cd7ad..ebeb3b9d 100644 --- a/src/ClashOfClans.Tests.Integration/ClansTests.cs +++ b/src/ClashOfClans.Tests.Integration/ClansTests.cs @@ -187,7 +187,7 @@ public async Task RetrieveClansClanWarLog() } // Assert - Assert.IsTrue(taskList.Any(), "Test data does not contain a clan with public war log!"); + Assert.IsTrue(taskList.Count != 0, "Test data does not contain a clan with public war log!"); foreach (ClanWarLog warLog in (await Task.WhenAll(taskList)).Select(v => (ClanWarLog)v)) { @@ -214,7 +214,7 @@ public async Task RetrieveInformationAboutClansCurrentClanWar() clanTags.ForEach(clanTag => taskList.Add(_coc.Clans.GetCurrentWarAsync(clanTag))); // Assert - Assert.IsTrue(taskList.Any(), "Test data does not contain a clan with public war log!"); + Assert.IsTrue(taskList.Count != 0, "Test data does not contain a clan with public war log!"); foreach (var currentWar in await Task.WhenAll(taskList)) { diff --git a/src/ClashOfClans.Tests.Integration/DumpExtensions.cs b/src/ClashOfClans.Tests.Integration/DumpExtensions.cs index b879a862..5774971b 100644 --- a/src/ClashOfClans.Tests.Integration/DumpExtensions.cs +++ b/src/ClashOfClans.Tests.Integration/DumpExtensions.cs @@ -116,12 +116,13 @@ public static string Dump(this ClanWarLeagueWarClan clan) private static string Dump(string players, IOrderedEnumerable members) { var sb = new StringBuilder(); + var membersArray = members.ToArray(); - if (members.Any()) + if (membersArray.Length != 0) { sb.Append(players); sb.Append(Environment.NewLine); - foreach (var member in members) + foreach (var member in membersArray) { sb.Append(member.Dump()); sb.Append(Environment.NewLine);