Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ Suggestion ] WavyElytra #22

Open
SzczurekYT opened this issue Jul 1, 2022 · 13 comments
Open

[ Suggestion ] WavyElytra #22

SzczurekYT opened this issue Jul 1, 2022 · 13 comments

Comments

@SzczurekYT
Copy link

Hello
I really like your mod I I tought that adding this same functionality for elytra would be could. Just imagine the waving wings. They also aren't static slab.
What do you think about that? If you would approve that maybe I could try to make this work and open PR?

@tr7zw
Copy link
Owner

tr7zw commented Jul 1, 2022

grafik
I guess this answers it. I have thought about it, but it's a bit tricky(especially in the scope I am/was planning). My idea was to split the wings into parts, keep the outer edge at the vanilla fixed location, but let the inner edge be simulated. This has a "few" challenges:

  • split the wings into parts that still render correctly(that's where the mod is currently stuck, cause the wings render a bit more tricky than the cape)
  • be able to animate the inner and outer vertices independently of each other so they can be attached to the stick animation
  • update the stick animation to be able to handle this correctly(changed directions of gravity/that when flying slowly the elytra doesn't fold into itself)

But yea, if you have the experience to work on points of this, be my guest(here on Github/Discord).

@tr7zw
Copy link
Owner

tr7zw commented Jul 1, 2022

Basically animated it in a style how the bone part outside is static(where the elytra have the thick edge), but animated on the thin inner part.

@SzczurekYT
Copy link
Author

Cool idea, but for me it also seems complicated, I think that you are more experianced than me.
Also I'm not sure if minecraft elytra is big enough to make this effect you are proposing visible.
For me cape's physic applied to elytra would be enough.

@tr7zw
Copy link
Owner

tr7zw commented Jul 1, 2022

Just blindly applying the cape physics would look really odd when it's just flopping around you while you are "gliding" with it.

@SzczurekYT
Copy link
Author

Yeah, some isGliding check would fix that.

@tr7zw
Copy link
Owner

tr7zw commented Jul 1, 2022

I mean to have it when not gliding is like 90% of the way there. So might as well add slight waves to it then.

@SzczurekYT
Copy link
Author

Exactly, the gliding part is less important because it looks fine in vanilla. With this mod it's just so odd for me that when I walk elytra has no movement.

@tr7zw
Copy link
Owner

tr7zw commented Jul 1, 2022

What I meant with that is, when you can move and animate it while walking, then you might as well also animate it while flying. The issue is getting to this point at all.

@SzczurekYT
Copy link
Author

Ah ok

@Aces-and-Jacks
Copy link

Aces-and-Jacks commented Jan 25, 2023

Unsure about how far you are with this, but as a temporary solution you could do something similar to this https://www.curseforge.com/minecraft/mc-mods/elytra-physics

Only a suggestion tho, if you don't want to do it that's fine as well

@tr7zw
Copy link
Owner

tr7zw commented Jan 25, 2023

That actually looks like a nice solution for when walking. I had more in flight/ or start/stop of flight in mind. The recently added Simulation V2, which runs in 3d internally, might help with this. Still would require redoing the entire elytra model to be animate-able.

@DelofJ
Copy link

DelofJ commented Feb 23, 2023

So you would let the animation when walking part to Elytra Physics and you do the flying animation part ?

@Aces-and-Jacks
Copy link

I'm guessing this is still on pause

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants