Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

respond_to? method only takes one parameter #89

Open
jcoyne opened this issue Aug 24, 2021 · 3 comments
Open

respond_to? method only takes one parameter #89

jcoyne opened this issue Aug 24, 2021 · 3 comments

Comments

@jcoyne
Copy link
Contributor

jcoyne commented Aug 24, 2021

/work/.rbenv/versions/2.7.2/lib/ruby/gems/2.7.0/gems/super_diff-0.8.0/lib/super_diff/object_inspection/inspection_tree_builders/default_object.rb:46: warning: Reform::Form::ActiveModel::Validations::Result::ResultErrors#respond_to?(:to_hash) uses the deprecated method signature, which takes one parameter
/work/.rbenv/versions/2.7.2/lib/ruby/gems/2.7.0/gems/reform-rails-0.2.2/lib/reform/form/active_model/validations.rb:165: warning: respond_to? is defined here

It should take an optional second argument include_all: https://ruby-doc.org/core-3.0.2/Object.html#method-i-respond_to-3F

@apotonick
Copy link
Member

Wow, I didn't know about this until now. The problem is here: https://github.com/trailblazer/reform-rails/blob/master/lib/reform/form/active_model/validations.rb#L165 Let me have a look at it! ☕

@apotonick
Copy link
Member

Would you like to PR the fix, @jcoyne ? 🍻 We have CI set up for all versions of Ruby, don't we, @yogeshjain999 ? 😂

@yogeshjain999
Copy link
Member

Would you like to PR the fix, @jcoyne ? 🍻 We have CI set up for all versions of Ruby, don't we, @yogeshjain999 ? 😂

Ah it's missing here, I'll add it here and verify other missing repos 🍻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants