Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create binaries for each release #492

Open
jayvdb opened this issue Jan 19, 2025 · 2 comments
Open

Create binaries for each release #492

jayvdb opened this issue Jan 19, 2025 · 2 comments

Comments

@jayvdb
Copy link

jayvdb commented Jan 19, 2025

I am now able to run cargo-unmaintained with configured ignores and see "No unmaintained packages found".

Now I would like to integrate this into CI, and the way I usually do this with Rust tools is to use https://github.com/taiki-e/install-action to install the binary , as it verifies the github release binary .

To do that, this repo would need to upload built binaries as part of each release. Most other Rust tools do this.

I recommend using https://github.com/taiki-e/upload-rust-binary-action to create the release with the binaries.

@smoelius
Copy link
Collaborator

Now I would like to integrate this into CI, and the way I usually do this with Rust tools is to use https://github.com/taiki-e/install-action to install the binary , as it verifies the github release binary .

To help me understand, the approach you're describing will cause install-action to use cargo-binstall to install the binary?

From Supported Tools:

If a tool not included in the list above is specified, this action uses cargo-binstall as a fallback.

@jayvdb
Copy link
Author

jayvdb commented Jan 20, 2025

Yes, cargo-binstall support would be an immediate benefit. But then I would also add it to the list of supported tools - I've added quite a few so far. Once it is added, the scripts there will verify the github binary hasnt been tampered with after it was first uploaded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants