Not checking for zero divisions anymore

Author: kevin-valerio

src/cmd/compile/internal/ssagen/intrinsics.go

@@ -1242,8 +1242,8 @@ func initIntrinsics(cfg *intrinsicBuildConfig) {
 	addF("math/bits", "Div64",
 		func(s *state, n *ir.CallExpr, args []*ssa.Value) *ssa.Value {
 			// check for divide-by-zero/overflow and panic with appropriate message
-			cmpZero := s.newValue2(s.ssaOp(ir.ONE, types.Types[types.TUINT64]), types.Types[types.TBOOL], args[2], s.zeroVal(types.Types[types.TUINT64]))
-			s.check(cmpZero, ir.Syms.Panicdivide)
+			// cmpZero := s.newValue2(s.ssaOp(ir.ONE, types.Types[types.TUINT64]), types.Types[types.TBOOL], args[2], s.zeroVal(types.Types[types.TUINT64]))
+			// s.check(cmpZero, ir.Syms.Panicdivide) // temporarily commented out
 			cmpOverflow := s.newValue2(s.ssaOp(ir.OLT, types.Types[types.TUINT64]), types.Types[types.TBOOL], args[0], args[2])
 			s.check(cmpOverflow, ir.Syms.Panicoverflow)
 			return s.newValue3(ssa.OpDiv128u, types.NewTuple(types.Types[types.TUINT64], types.Types[types.TUINT64]), args[0], args[1], args[2])

src/cmd/compile/internal/ssagen/ssa.go

@@ -5378,8 +5378,8 @@ func (s *state) intDivide(n ir.Node, a, b *ssa.Value) *ssa.Value {
 	}
 	if needcheck {
 		// do a size-appropriate check for zero
-		cmp := s.newValue2(s.ssaOp(ir.ONE, n.Type()), types.Types[types.TBOOL], b, s.zeroVal(n.Type()))
-		s.check(cmp, ir.Syms.Panicdivide)
+		// cmp := s.newValue2(s.ssaOp(ir.ONE, n.Type()), types.Types[types.TBOOL], b, s.zeroVal(n.Type()))
+		// s.check(cmp, ir.Syms.Panicdivide) // temporarily commented out
 	}
 
 	return s.newValue2(s.ssaOp(n.Op(), n.Type()), a.Type, a, b)
@@ -5825,8 +5825,8 @@ func (s *state) intDiv(n ir.Node, a, b *ssa.Value) *ssa.Value {
 				}
 			}
 			if needcheck {
-				cmp := s.newValue2(s.ssaOp(ir.ONE, n.Type()), types.Types[types.TBOOL], b, s.zeroVal(n.Type()))
-				s.check(cmp, ir.Syms.Panicdivide)
+				// cmp := s.newValue2(s.ssaOp(ir.ONE, n.Type()), types.Types[types.TBOOL], b, s.zeroVal(n.Type()))
+				// s.check(cmp, ir.Syms.Panicdivide) // temporarily commented out
 			}
 			return s.newValue2(s.ssaOp(n.Op(), n.Type()), a.Type, a, b)
 		}
@@ -5842,8 +5842,8 @@ func (s *state) intDiv(n ir.Node, a, b *ssa.Value) *ssa.Value {
 	}
 	if needcheck {
 		// do a size-appropriate check for zero
-		cmp := s.newValue2(s.ssaOp(ir.ONE, n.Type()), types.Types[types.TBOOL], b, s.zeroVal(n.Type()))
-		s.check(cmp, ir.Syms.Panicdivide)
+		// cmp := s.newValue2(s.ssaOp(ir.ONE, n.Type()), types.Types[types.TBOOL], b, s.zeroVal(n.Type()))
+		// s.check(cmp, ir.Syms.Panicdivide) // temporarily commented out
 	}
 
 	// If overflow detection is disabled, just perform the division