Use VAST's fallthrough visitor #33
Labels
dependencies
External project dependencies
enhancement ✨
New feature or request
priority:low
Low-priority tasks
Macroni's visitors should inherit from VAST's new
fallthrough_visitor
struct so that they only need to define the visit methods relevant to them.Currently, each of Macroni's visitors that inherit from
visitor_base
need to define all their visit method in order to be concrete structs. However, this adds a lot of boilerplate code since Macroni's visitors only do special actions for one or two visit methods, and just returnnullptr
for all else. So to reduce boilerplate Macroni's visitors should inherit from a struct that already defines all its visitors to returnnullptr
. There are PRs open which use a custom-defined empty visitor; however once VAST merges this commit Macroni's structs should just inherit from thefallthrough_visitor
.The text was updated successfully, but these errors were encountered: