Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compilation with warnings-as-errors should be optional #159

Open
ekilmer opened this issue May 20, 2021 · 0 comments
Open

Compilation with warnings-as-errors should be optional #159

ekilmer opened this issue May 20, 2021 · 0 comments
Labels

Comments

@ekilmer
Copy link
Contributor

ekilmer commented May 20, 2021

Compiling with warnings-as-errors is fine if your compiler doesn't change, but as new compilers are released, new warnings might pop up and fail a compilation for an end-user.

The user should be able to turn on warnings-as-errors through a CMake option, and this option should be disabled by default in the CMakeLists.txt file but enabled for all CI runs.

The associated compiler flags are -Werror for gcc and clang, and /WX for MSVC compilers. These are located in https://github.com/trailofbits/pe-parse/blob/master/cmake/compilation_flags.cmake

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant