Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ability to customize renderFileName #5029

Closed
2 tasks done
devxpy opened this issue Mar 27, 2024 · 4 comments
Closed
2 tasks done

ability to customize renderFileName #5029

devxpy opened this issue Mar 27, 2024 · 4 comments
Labels

Comments

@devxpy
Copy link

devxpy commented Mar 27, 2024

Initial checklist

  • I understand this is a feature request and questions should be posted in the Community Forum
  • I searched issues and couldn’t find anything (or linked relevant results below)

Problem

The default length for renderFileName is too small.

Solution

Can we please get a way to customize this?

image

Alternatives

Do this in css/js so the preview text fits the width always

@devxpy devxpy added the Feature label Mar 27, 2024
@Murderlon
Copy link
Member

Hi, many people like to use Dashboard but change one small thing and therefor need a new option. If we were to do this every time we’d have a hundred options. The better long-term alternative is to make Uppy UI components composable, which we’re thinking of, but supersede this kind of issues.

If you can find a way to improve this without introducing an option we'd gladly take a contribution, otherwise we can close this for now

@aduh95
Copy link
Contributor

aduh95 commented Mar 27, 2024

Do this in css/js so the preview text fits the width always

That's probably possible, we'd have to put the file extension is a separate HTML element, then we can use CSS to automatically cut the text that overflows.

@Murderlon
Copy link
Member

That might be tricky for accessibility. Semantically the file has to be readable by a screenreader in one go.

@Murderlon
Copy link
Member

Closing this as this should be superseded by #5379

@Murderlon Murderlon closed this as not planned Won't fix, can't repro, duplicate, stale Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants