Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thumbnails from cloud companion uploaders (Google Drive, Dropbox, etc) sometimes do not display before upload #5389

Open
2 tasks done
tyler-dot-earth opened this issue Aug 2, 2024 · 1 comment
Labels

Comments

@tyler-dot-earth
Copy link
Contributor

tyler-dot-earth commented Aug 2, 2024

Initial checklist

  • I understand this is a bug report and questions should be posted in the Community Forum
  • I searched issues and couldn’t find anything (or linked relevant results below)

Link to runnable example

No response

Steps to reproduce

  1. Add various cloud companion uploaders (Google Drive, Dropbox, Box, OneDrive, etc)
  2. Pick a photo or file from one of those cloud drives. The filetype itself does not seem to matter.
  3. It sometimes (but not all the time) does not display the thumbnail properly

The upload works fine, it's just an issue with the thumbnail before upload.

Note that I'm using Transloadit + Uppy, so the companion servers are managed by Transloadit.

I can't see any rhyme or reason to this - I suspect it's maybe a hotlinking issue, though it's just a guess based on how it looks.

Screenshot:

image

Expected behavior

The chosen file's thumbnail should always display fine.

Actual behavior

The chosen file's thumbnail does not always display fine.

@Murderlon
Copy link
Member

Hi, this is expected as very few providers have thumbnails APIs so only those who support it will show up. This is on purpose, as sending the whole file down to the client defeats the purpose of Companion, which should do all the heavy lifting.

The UI should not have a broken icon though, it should fallback to our icons.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants