-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade GeoIP Lite to GeoLite2 #1104
Comments
That would be very difficult because dont exist a class API done for the new format of the database. Maybe some experienced coder with knowing of C++ or Java could adapt that code to Pascal. |
Or maybe package the legacy version in the release, need to confirm about its license and ours. |
Looks like there is a v1 example file here: https://www.maxmind.com/download/geoip/api/pascal/Sample.pas, not sure if they just haven't v2 sample yet. |
@antekgla I found another choice maybe: it's easy to deal with csv file :) |
Another choices: Maybe this code can help us understand GeoLite2 :) |
The problem with that is the use geoip.pas implementation
uses GeoIP; that unit is the main unit because is the one what deals directly with the Maxmind database and is for v1. |
Or perhaps we could use a web service(get method)/3rd party api to get geo result instead of an offline database? Pros:
Cons:
|
@rzcat I prefer not to, the operation will be slow, IP locations don't change that fast and frequently, I found other free DBs above maybe we could use. |
@PeterDaveHello |
@rzcat that's not a good idea, we don't need to make it so complex |
Just compile the C library from https://github.com/maxmind/libmaxminddb Or just compile and use the library (i.e. libmaxminddb.dll for windows) directly https://github.com/maxmind/libmaxminddb/blob/master/doc/libmaxminddb.md. |
@PeterDaveHello |
If we can import from GeoIP2, I suppose we could do the same thing just as the version 1(instead of another import step)? If we are allowed to "import" data, then we should deal with "conflicts" in the dataset/database, or every import will clean up the old data. What do you think? |
Let's just keep the legacy one working first: Don't have enough time to dig or rewrite GeoIP.pas yet. |
GeoIP Data download 404 error (v5.16.0) |
@angel228282 you should try v5.17 which includes the fix |
https://blog.maxmind.com/2019/12/18/significant-changes-to-accessing-and-using-geolite2-databases/ |
Can I add a manual import feature? |
@mS0gxokXEsg5ysJ7J79kzWiqO1fHgFA6ZR8eEls The workaround is working right now, not sure why if you need it? Actually, you can manually do that without a feature added. |
Been missing this feature! Can't get flags, legacy db or other. Tried with fresh install and by doing manually. On picking Show Country Flags, alert shows: "Flag images archive is needed... Download this archive now?" But clicking Yes brings up a second alert: "SSL/TLS support is not compiled!" Can this currently be made to work? Many thanks for great UI. |
GeoLite v1 is eol now, we'll need to move to GeoLite v2
https://dev.maxmind.com/geoip/legacy/geolite/
cc #977 @transmission-remote-gui/development
The text was updated successfully, but these errors were encountered: