-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dark theme for Windows #1300
Comments
Implement native support in the development environment (Lazarus), suggest changes to the program code. Offer your help. Welcome. |
Yes please, a dark theme for Windows is the only thing missing in this wonderful remote |
There seems to be a way to detect if windows is using Dark/Light mode here although there's still no native support implemented in Lazarus itself. Pretty sad that this has been going on for years with no native support yet. |
This might be useful to devs using Lazarus out there: |
I'm so confused coming in to this in 2023. In the main Readme.md there is a screenshot with there being a great dark mode in use. Separate to that, how can a Windows user find AutoColors.pas and Main.pas and implement the changes above? Where do I find these files? I see the "You can also set your win to a contrast theme. E.g. save this one as contrast.theme and open" which I assume is talking about a Windows theme, but my windows theming/colors is all the way right currently, I'm really apprehensive to try pursue that as a fix unless someone can tell me it's written with someone already using Windows 10 Dark Mode successfully and it's just a tweak to that existing color profile/theme. |
.pas files are Pascal source code, Delphi, which Transgui is built upon, is an evolution of the Pascal programming language. So I'm taking it, it's not simply a matter of editing a configuration file, for changes to source code requires some level of programming skills and being able to submit a PR to the project. IOW if you have to ask, you might not be able to do it yourself. Transgui has not seen a new release in a few years, and while not abandoned, even if you were to submit a working patch, you'd not be able to use it unless you build it yourself. There is, however, a fork by @xavery that's been actively worked on and has been releasing new builds. |
@hetzjagd Pretty much what @Mrnofish said. Unfortunately, there are no user serviceable parts here with regards to this. As it stands now, dark themes are supported on both Linux and macOS. On Linux, this depends on your desktop environment's theme and the version of Transgui you're using (GTK or Qt5, my builds are Qt5 exclusively) - if your GTK/Qt5 theme is dark, Transgui adapts to it. The screenshot in this project's readme comes from a Linux GTK (from the looks of it) version. I'll have a look but I can't promise anything, there must be something I'm missing about dark theme support on Windows and will have to read up. |
Re: dark theme on windows, from a purely end user pov, I'm afraid you hit the nail squarely on the head. It's probably much different and easier for universal or whatever Microsoft calls "new style" windows apps these days, as those have UIs based on web-like technology (or this is my rough understanding of the matter). With that said it should be possible to "back port" the GTK version to windows, and reuse the work done there on dark theming. I have no idea how much work is that and what drawbacks the switch may entail, though. If I had to take a guess, I'd say transgui would benefit more from core work on functionality, but thats just my opinion. OTOH deploying dark theme on windows, despite being essentially cosmetic, is highly visible work that may attract attention and users. Paradoxically, upgrading openssl is "less exciting" stuff your average end user might not even care too much especially if they don't manage seed boxes over the open internet, but rather stick to vpns and local networks. Just my two cents. |
Okay. Still very confused about all this. It looks like support for dark mode in Win32 applications is generally in a kind of a messy state where it's officially not supported but can actually be enabled thanks to the fantastic work done in https://github.com/ysc3839/win32-darkmode which uses undocumented APIs available in Windows 10 1809 and later. However, after experimenting with the code in that repo it became clear that just calling Anyhow, incorporating this into transgui would require the work of somebody who knows what they're doing in both Pascal (so the C++ code can be ported) and Windows (so any changes to message loops can be made). This effectively makes me completely unfit for this task, unfortunately.
If the Windows version of GTK uses themes in a way similar to the Linux version, it could be done by "just" shipping the Windows-GTK version with a selectable dark theme file. However, if it does or how does one even begin to create a Windows-GTK version of a Lazarus application is completely unknown to me. |
Please add the dark theme for Windows.
The text was updated successfully, but these errors were encountered: