Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several dialogs have [Escape] for yes instead of no (defaults) #1450

Open
wally-crunk opened this issue Mar 31, 2023 · 5 comments
Open

Several dialogs have [Escape] for yes instead of no (defaults) #1450

wally-crunk opened this issue Mar 31, 2023 · 5 comments

Comments

@wally-crunk
Copy link

wally-crunk commented Mar 31, 2023

  1. Mac OS Ventura 13.3 (22E252)
  2. Transmission Daemon 4.0.2 (2a57b17031)
  3. Transmission GUI 5.18 3fb1d33

Several of the Warning dialog boxes in Transmission-GUI have Escape key mapped to Yes instead of No, which is definitely not the expected behavior.

For example, [Escape] causes Verification to start, but Cancel or "No" is what would be expected from the [Esc] key:

screenshot to verify

For example,[Escape] causes the Data to be deleted -- cancel or "No" is what would be expected from the [Esc] key:

Screenshot to remove

Similar but not quite the same as: (#1382)

@pwinn
Copy link

pwinn commented Oct 15, 2023

Yes, this is horrifying, and has resulted in unwanted data loss.

@wally-crunk
Copy link
Author

@pwinn I believe @xavery is addressing this issue in their fork.

@lighterowl
Copy link
Contributor

@wally-crunk I don't think this particular thing is fixed yet, though I will add an issue so I can at least track this.

@pwinn
Copy link

pwinn commented Nov 22, 2023

@wally-crunk I switched to that fork a few days ago, and you're right!

@xavery I tested this in v5.18.3.f build b036107, and it works as expected: Right-click, Remove torrent and data, then Esc closes the confirmation dialog and leaves the torrent in place. Whew!

@lighterowl
Copy link
Contributor

@pwinn That's great to know! I don't remember doing anything to address this specifically so must've been something that got fixed in Lazarus in the meantime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants