[firebase_analytics] Added Navigator.pushReplacement screen tracking (flutter#1428)

* Track Navigator.pushReplacement screen changes

Currently only standard push and pops were automatically logged to Firebase. However, this resulted in missing screen_view events for apps with more complex navigation.

* Added test for pushReplacement

Author: thomas-stockx

AUTHORS

@@ -27,3 +27,4 @@ Mike Diarmid <[email protected]>
 Invertase <[email protected]>
 Elliot Hesp <[email protected]>
 Katarina Sheremet <[email protected]>
+Thomas Stockx <[email protected]>

packages/firebase_analytics/CHANGELOG.md

@@ -1,3 +1,7 @@
+## 2.1.1
+
+* Added screen_view tracking of Navigator.pushReplacement
+
 ## 2.1.0
 
 * Add Login event support

packages/firebase_analytics/lib/observer.dart

@@ -32,6 +32,10 @@ String defaultNameExtractor(RouteSettings settings) => settings.name;
 ///   settings: RouteSettings(name: '/contact/123',
 ///   builder: ContactDetail(123)))),
 ///
+/// Navigator.pushReplacement(context, MaterialPageRoute(
+///   settings: RouteSettings(name: '/contact/123',
+///   builder: ContactDetail(123)))),
+///
 /// Navigator.pop(context);
 /// ```
 ///
@@ -94,6 +98,14 @@ class FirebaseAnalyticsObserver extends RouteObserver<PageRoute<dynamic>> {
     }
   }
 
+  @override
+  void didReplace({Route<dynamic> newRoute, Route<dynamic> oldRoute}) {
+    super.didReplace(newRoute: newRoute, oldRoute: oldRoute);
+    if (newRoute is PageRoute) {
+      _sendScreenView(newRoute);
+    }
+  }
+
   @override
   void didPop(Route<dynamic> route, Route<dynamic> previousRoute) {
     super.didPop(route, previousRoute);

packages/firebase_analytics/pubspec.yaml

@@ -3,7 +3,7 @@ description: Flutter plugin for Google Analytics for Firebase, an app measuremen
   solution that provides insight on app usage and user engagement on Android and iOS.
 author: Flutter Team <[email protected]>
 homepage: https://github.com/flutter/plugins/tree/master/packages/firebase_analytics
-version: 2.1.0
+version: 2.1.1
 
 flutter:
   plugin:

packages/firebase_analytics/test/observer_test.dart

@@ -57,6 +57,16 @@ void main() {
       verify(analytics.setCurrentScreen(screenName: 'route')).called(1);
     });
 
+    test('setCurrentScreen on route pushReplacement', () {
+      final PageRoute<dynamic> route = MockPageRoute();
+      final PageRoute<dynamic> previousRoute = MockPageRoute();
+      when(route.settings).thenReturn(const RouteSettings(name: 'route'));
+
+      observer.didReplace(newRoute: route, oldRoute: previousRoute);
+
+      verify(analytics.setCurrentScreen(screenName: 'route')).called(1);
+    });
+
     test('uses nameExtractor', () {
       observer = FirebaseAnalyticsObserver(
         analytics: analytics,