Skip to content

Commit 8cd76d2

Browse files
yadaniyilcollinjackson
authored andcommitted
[firebase_analytics] Fixes errors in firebase_analytics docs (flutter#1490)
Fixes navigation examples in firebase_analytics docs
1 parent 9a41270 commit 8cd76d2

File tree

3 files changed

+11
-7
lines changed

3 files changed

+11
-7
lines changed

packages/firebase_analytics/CHANGELOG.md

+4
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
## 2.1.1+2
2+
3+
* Fixed errors in code sample for `FirebaseAnalyticsObserver`.
4+
15
## 2.1.1+1
26

37
* Added hyperlinks to example app reference in README.md.

packages/firebase_analytics/lib/observer.dart

+6-6
Original file line numberDiff line numberDiff line change
@@ -28,13 +28,13 @@ String defaultNameExtractor(RouteSettings settings) => settings.name;
2828
/// ```dart
2929
/// Navigator.pushNamed(context, '/contact/123');
3030
///
31-
/// Navigator.push(context, MaterialPageRoute(
32-
/// settings: RouteSettings(name: '/contact/123',
33-
/// builder: ContactDetail(123)))),
31+
/// Navigator.push<void>(context, MaterialPageRoute(
32+
/// settings: RouteSettings(name: '/contact/123'),
33+
/// builder: (_) => ContactDetail(123)));
3434
///
35-
/// Navigator.pushReplacement(context, MaterialPageRoute(
36-
/// settings: RouteSettings(name: '/contact/123',
37-
/// builder: ContactDetail(123)))),
35+
/// Navigator.pushReplacement<void>(context, MaterialPageRoute(
36+
/// settings: RouteSettings(name: '/contact/123'),
37+
/// builder: (_) => ContactDetail(123)));
3838
///
3939
/// Navigator.pop(context);
4040
/// ```

packages/firebase_analytics/pubspec.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ description: Flutter plugin for Google Analytics for Firebase, an app measuremen
33
solution that provides insight on app usage and user engagement on Android and iOS.
44
author: Flutter Team <[email protected]>
55
homepage: https://github.com/flutter/plugins/tree/master/packages/firebase_analytics
6-
version: 2.1.1+1
6+
version: 2.1.1+2
77

88
flutter:
99
plugin:

0 commit comments

Comments
 (0)