Skip to content

Commit d7e22f4

Browse files
committed
beginning s3 client
1 parent 150776e commit d7e22f4

File tree

1 file changed

+11
-7
lines changed

1 file changed

+11
-7
lines changed

esti/s3_gateway_test.go

+11-7
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ import (
1515

1616
"github.com/aws/aws-sdk-go-v2/aws"
1717
"github.com/aws/aws-sdk-go-v2/service/s3"
18+
"github.com/aws/aws-sdk-go-v2/service/s3/types"
1819
"github.com/go-openapi/swag"
1920

2021
"github.com/minio/minio-go/v7"
@@ -188,13 +189,16 @@ func TestS3IfNoneMatch(t *testing.T) {
188189
ctx, _, repo := setupTest(t)
189190
defer tearDownTest(repo)
190191

191-
client := createS3Client(endpointURL+apiutil.BaseURL, t)
192+
client := createS3Client(endpointURL, t)
193+
bucketName := "test-bucket"
192194
_, err := client.CreateBucket(ctx, &s3.CreateBucketInput{
193-
Bucket: aws.String("test-bucket"),
195+
Bucket: aws.String(bucketName),
196+
CreateBucketConfiguration: &types.CreateBucketConfiguration{
197+
LocationConstraint: types.BucketLocationConstraint("us-east-1"),
198+
},
194199
})
195200

196201
require.NoError(t, err, "Error creating bucket")
197-
//func (c *Client) CreateBucket(ctx context.Context, params *CreateBucketInput, optFns ...func(*Options)) (*CreateBucketOutput, error)
198202

199203
type TestCase struct {
200204
Path string
@@ -221,13 +225,13 @@ func TestS3IfNoneMatch(t *testing.T) {
221225
for tc := range objects {
222226
// Create the PutObject request
223227
_, err := client.PutObject(ctx, &s3.PutObjectInput{
224-
Bucket: aws.String("test-bucket"),
228+
Bucket: aws.String(bucketName),
225229
Key: aws.String(tc.Path),
226230
Body: strings.NewReader(tc.Content),
227231
})
228-
if (err != nil) != tc.ExpectError {
229-
t.Errorf("unexpected error for Path %s with If-None-Match %q: %v", tc.Path, tc.IfNoneMatch, err)
230-
}
232+
233+
require.NoError(t, err, "Error uploading bucket")
234+
231235
}
232236
}()
233237
}

0 commit comments

Comments
 (0)