[CR] Put all "const ...ContentLength..." together and document them

Author: arielshaqed

esti/s3_gateway_test.go

@@ -329,7 +329,6 @@ func TestS3HeadBucket(t *testing.T) {
 }
 
 func TestS3CopyObjectMultipart(t *testing.T) {
-	const minDataContentLengthForMultipart = 5 << 20
 	ctx, _, repo := setupTest(t)
 	defer tearDownTest(repo)
 

esti/system_test.go

@@ -144,11 +144,20 @@ func deleteRepositoryIfAskedTo(ctx context.Context, repositoryName string) {
 	}
 }
 
-const randomDataContentLength = 16
-
-// largeDataContentLength is >5 MiB, which is large enough to require
-// multipart operations.
-const largeDataContentLength = 6 << 20
+const (
+	// randomDataContentLength is the content length used for small
+	// objects.  It is intentionally not a round number.
+	randomDataContentLength = 16
+
+	// minDataContentLengthForMultipart is the content length for all
+	// parts of a multipart upload except the last.  Its value -- 5MiB
+	// -- is defined in the S3 protocol, and cannot be changed.
+	minDataContentLengthForMultipart = 5 << 20
+
+	// largeDataContentLength is >minDataContentLengthForMultipart,
+	// which is large enough to require multipart operations.
+	largeDataContentLength = 6 << 20
+)
 
 func uploadFileRandomDataAndReport(ctx context.Context, repo, branch, objPath string, direct bool) (checksum, content string, err error) {
 	objContent := randstr.String(randomDataContentLength)