Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating bare repository skips storage namespace validation #3165

Open
itaiad200 opened this issue Apr 4, 2022 · 9 comments · May be fixed by #8364
Open

Creating bare repository skips storage namespace validation #3165

itaiad200 opened this issue Apr 4, 2022 · 9 comments · May be fixed by #8364
Assignees
Labels
area/API Improvements or additions to the API good first issue Good for newcomers team/versioning-engine Team versioning engine

Comments

@itaiad200
Copy link
Contributor

Some bad things can happen as a result, e.g.

  • Creating a repo with no storage access
  • Creating multiple repositories under the same namespace
@itaiad200 itaiad200 added area/API Improvements or additions to the API team/versioning-engine Team versioning engine labels Apr 4, 2022
Copy link

github-actions bot commented Nov 1, 2023

This issue is now marked as stale after 90 days of inactivity, and will be closed soon. To keep it, mark it with the "no stale" label.

@github-actions github-actions bot added the stale label Nov 1, 2023
@itaiad200 itaiad200 added no stale Using this label will prevent items from being marked as stale and removed stale labels Nov 2, 2023
@github-actions github-actions bot added the stale label Mar 20, 2024
@arielshaqed arielshaqed removed no stale Using this label will prevent items from being marked as stale stale labels Mar 27, 2024
@itaiad200 itaiad200 added the good first issue Good for newcomers label Jun 24, 2024
@N-o-Z N-o-Z assigned N-o-Z and unassigned N-o-Z Nov 7, 2024
@tkalir
Copy link

tkalir commented Nov 10, 2024

hi, please assign me the issue if it's available

@N-o-Z N-o-Z assigned tkalir and unassigned N-o-Z Nov 10, 2024
@N-o-Z
Copy link
Member

N-o-Z commented Nov 10, 2024

hi, please assign me the issue if it's available

Done!

@tkalir
Copy link

tkalir commented Nov 12, 2024

I see that the mentioned validations (write access check and checking for existing repo at the same storage namespace) occur right now only for non-bare non-readonly repos.
I guess that these checks should be added only for non-readonly bare repos?

@N-o-Z
Copy link
Member

N-o-Z commented Nov 12, 2024

@idanovo any reason why we didn't add namespace validation on read only repos?

@idanovo
Copy link
Contributor

idanovo commented Nov 13, 2024

@idanovo any reason why we didn't add namespace validation on read-only repos?

@N-o-Z Yes- since this is a read-only repository, there is no harm in case the storage namespace we are using is already used by another repository or if we don't have write permissions for this namespace.
We can have for example one "regular" repository for this namespace and another read-only repo(s) for this namespace.
Maybe we should document this one better as it took me some time to remember we had done it.

@N-o-Z
Copy link
Member

N-o-Z commented Nov 21, 2024

@idanovo any reason why we didn't add namespace validation on read-only repos?

@N-o-Z Yes- since this is a read-only repository, there is no harm in case the storage namespace we are using is already used by another repository or if we don't have write permissions for this namespace. We can have for example one "regular" repository for this namespace and another read-only repo(s) for this namespace. Maybe we should document this one better as it took me some time to remember we had done it.

@idanovo Thanks for the explanation. I believe this indeed deserves documentation

@idanovo
Copy link
Contributor

idanovo commented Nov 24, 2024

@N-o-Z #8396

@arielshaqed
Copy link
Contributor

I would like to understand why this is the right thing to do. Creating a bare repo is intentionally a plumbing operation, and I am afraid of limiting it, especially at this late stage.

For instance, if we make this change then restoring a repository becomes harder: I need to worry about whether dummy already exists in the repository.

This needs a few minutes of face-to-face discussion; fortunately we have some coming up this week!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/API Improvements or additions to the API good first issue Good for newcomers team/versioning-engine Team versioning engine
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants