support putifabsent #8428
support putifabsent #8428
Conversation
ItamarYuran
added
the
include-changelog
E2E Test Results - DynamoDB Local - Local Block Adapter |
E2E Test Results - Quickstart |
| ErrObjectExists: { | ||
| Code: "ErrObjectExists", | ||
| Description: "Object path already exists in DB", | ||
| HTTPStatusCode: http.StatusNotModified, |
There was a problem hiding this comment.
The correct error is PreconditionFailed with status code 412 (StatusPreconditionFailed).
As for the description, the exact AWS message is:
At least one of the pre-conditions you specified did not hold
let's stick to what AWS returns.
| @@ -298,6 +298,11 @@ func handlePut(w http.ResponseWriter, req *http.Request, o *PathOperation) { | |||
| o.Incr("put_object", o.Principal, o.Repository.Name, o.Reference) | |||
| storageClass := StorageClassFromHeader(req.Header) | |||
| opts := block.PutOpts{StorageClass: storageClass} | |||
| err := o.checkIfAbsent(req) | |||
There was a problem hiding this comment.
This intention is right but not the approach.
In the current version the function checkIfAbsent implements checkIfAbsent by doing Get to the object and then Put. This is not gonna work because the Get->Put operation is not atomic.
The idea of the feature is that AWS implements this and provide atomicity out of the box.
Instead, our S3 Gateway should only forward the request to AWS and let them handle the precondition check.
Example implementation:
- add additional field to
opts := block.PutOpts{StorageClass: storageClass, IfNoneMatch}(one line above) that check if the header exist and sets it. - let the ops propagate down to the blockstore adapter and then use it when calling PutObject as an option. We have a challenge here see below 👇 .
Challenge with PutObject call:
Our AWS SDK is outdated, so it does not contain the built-in option in the new version IfNoneMatch.
We have 2 options:
a. Upgrade the AWS SDK (preferable) after verifying there no breaking changes (separate PR)
b. Use the request middleware options that the current AWS SDK version provides to propagate the header.
- in AWS SDK introduces in service/s3/v1.60.0
NOTE: Same should apply for Multipart Uploads
Closes #8380
Change Description
Added support for if-none-match header.
The header can be used for putObject or complete-multipart-upload operations.
changes were tested manually. In case of a collision an error with http status 304 will return, as in aws cli.