Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LangChain LakeFSLoader: load document metadata tags #8408

Open
Isan-Rivkin opened this issue Dec 9, 2024 · 0 comments
Open

LangChain LakeFSLoader: load document metadata tags #8408

Isan-Rivkin opened this issue Dec 9, 2024 · 0 comments

Comments

@Isan-Rivkin
Copy link
Contributor

Problem

Currently our LakeFSLoader loads document without metadata object tags and only adds the logical path tag as source key to Document. We ignore any user set object metadata.

So What?

This means that the LakeFSLoader is not helpful the moment I need to use object metadata for embedding, retrieval etc.
For example, very common case in RAG of time weighted retriever.

To use the object tags I would have to implement custom logic for this listing all documents and getting the tags, bottom line it means I don't have a use in LakeFSLoader since I would have to load everything anyway myself.

Suggestion

When calling LakeFSLoader constructor in Langchain, add additional optional param to indicate id metadata tags should be added to the Document.

loader = LakeFSLoader(repo="...",ref="...",path="...", with_metadata=True) 
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants