Skip to content

Commit c54604f

Browse files
feat: chart axis labels (#1049)
* add first draft * update padding * update funnel padding constants
1 parent f765a79 commit c54604f

File tree

24 files changed

+1117
-579
lines changed

24 files changed

+1117
-579
lines changed

.github/ISSUE_TEMPLATE/feature-request.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ body:
77
attributes:
88
value: |
99
**Before submitting a feature request**
10-
10+
1111
The issue list is reserved for bug reports and feature requests. If you have a usage question, you can:
1212
1313
- Read the [documentation](https://www.tremor.so/docs/getting-started/installation)

.github/pull_request_template.md

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ https://github.com/tremorlabs/tremor/blob/main/CONTRIBUTING.md
44
-->
55

66
<!-- PULL REQUEST TEMPLATE -->
7+
78
**Description**
89

910
<!--- Describe your changes in detail -->
@@ -16,6 +17,7 @@ https://github.com/tremorlabs/tremor/blob/main/CONTRIBUTING.md
1617
<!--- If fixing a bug, there should be an issue describing it with steps to reproduce -->
1718

1819
**What kind of change does this PR introduce?** (check at least one)
20+
1921
<!-- (Update "[ ]" to "[x]" to check a box) -->
2022

2123
- [ ] Bug fix (non-breaking change which fixes an issue)
@@ -40,10 +42,10 @@ If yes, please describe the impact and migration path for existing applications:
4042

4143
**Screenshots (if appropriate):**
4244

43-
4445
**The PR fulfils these requirements:**
4546

4647
<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->
48+
4749
- [ ] It's submitted to the `main` branch
4850
- [ ] When resolving a specific issue, it's referenced in the related issue section above
4951
- [ ] My change requires a change to the documentation. (Managed by Tremor Team)

.github/workflows/build.yaml

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ on:
1111
- '**'
1212
- '!main'
1313

14-
1514
jobs:
1615
build:
1716
name: Build dist
@@ -33,5 +32,4 @@ jobs:
3332
- name: unit tests
3433
run: npm run tests
3534
- name: build
36-
run: npm run build
37-
35+
run: npm run build

.storybook/main.js

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ module.exports = {
3838
},
3939
},
4040
"@storybook/addon-webpack5-compiler-babel",
41-
"@chromatic-com/storybook"
41+
"@chromatic-com/storybook",
4242
],
4343

4444
framework: {
@@ -56,7 +56,9 @@ module.exports = {
5656
return config;
5757
},
5858

59-
docs: {
60-
autodocs: true,
59+
docs: {},
60+
61+
typescript: {
62+
reactDocgen: "react-docgen-typescript",
6163
},
6264
};

.storybook/manager.js

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
1-
import { addons } from '@storybook/manager-api';
2-
import { themes } from '@storybook/theming';
3-
import tremorTheme from './tremorTheme';
1+
import { addons } from "@storybook/manager-api";
2+
import { themes } from "@storybook/theming";
3+
import tremorTheme from "./tremorTheme";
44

55
addons.setConfig({
6-
theme: tremorTheme,
7-
});
6+
theme: tremorTheme,
7+
});

.storybook/preview.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,3 +33,4 @@ export const decorators = [
3333
attributeName: "data-mode",
3434
}),
3535
];
36+
export const tags = ["autodocs"];

CODE_OF_CONDUCT.md

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -17,23 +17,23 @@ diverse, inclusive, and healthy community.
1717
Examples of behavior that contributes to a positive environment for our
1818
community include:
1919

20-
* Demonstrating empathy and kindness toward other people
21-
* Being respectful of differing opinions, viewpoints, and experiences
22-
* Giving and gracefully accepting constructive feedback
23-
* Accepting responsibility and apologizing to those affected by our mistakes,
20+
- Demonstrating empathy and kindness toward other people
21+
- Being respectful of differing opinions, viewpoints, and experiences
22+
- Giving and gracefully accepting constructive feedback
23+
- Accepting responsibility and apologizing to those affected by our mistakes,
2424
and learning from the experience
25-
* Focusing on what is best not just for us as individuals, but for the
25+
- Focusing on what is best not just for us as individuals, but for the
2626
overall community
2727

2828
Examples of unacceptable behavior include:
2929

30-
* The use of sexualized language or imagery, and sexual attention or
30+
- The use of sexualized language or imagery, and sexual attention or
3131
advances of any kind
32-
* Trolling, insulting or derogatory comments, and personal or political attacks
33-
* Public or private harassment
34-
* Publishing others' private information, such as a physical or email
32+
- Trolling, insulting or derogatory comments, and personal or political attacks
33+
- Public or private harassment
34+
- Publishing others' private information, such as a physical or email
3535
address, without their explicit permission
36-
* Other conduct which could reasonably be considered inappropriate in a
36+
- Other conduct which could reasonably be considered inappropriate in a
3737
professional setting
3838

3939
## Enforcement Responsibilities
@@ -106,7 +106,7 @@ Violating these terms may lead to a permanent ban.
106106
### 4. Permanent Ban
107107

108108
**Community Impact**: Demonstrating a pattern of violation of community
109-
standards, including sustained inappropriate behavior, harassment of an
109+
standards, including sustained inappropriate behavior, harassment of an
110110
individual, or aggression toward or disparagement of classes of individuals.
111111

112112
**Consequence**: A permanent ban from any sort of public interaction within

CONTRIBUTING.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22

33
Thanks for your interest in contributing to Tremor. Please take a moment to review this document before submitting a pull request. This document will outline how to submit changes to this repository and which conventions to follow. If you are ever in doubt about anything we encourage you to reach out on [Slack](https://join.slack.com/t/tremor-community/shared_invite/zt-1u8jqmcmq-Fdr9B6MbnO7u8FkGh~2Ylg), [open a discussion](#discussions), or [shoot us an email](mailto:[email protected]).
44

5-
65
### **Prerequisites**
76

87
- You are familiar with [issues](#issues) and [pull requests](#pulls).
@@ -55,7 +54,8 @@ We encourage that you do a self-review prior to requesting a review. To do a sel
5554
### **Documentation**
5655

5756
- We generally encourage you to document your changes through comments in your code.
58-
- If you alter user-facing behavior you must provide documentation for such changes, for reference, check out [our documentation]([url](https://www.tremor.so/docs/getting-started/introduction)).
57+
- If you alter user-facing behavior you must provide documentation for such changes, for reference, check out [our documentation](<[url](https://www.tremor.so/docs/getting-started/introduction)>).
5958

6059
### **Licensing**
60+
6161
By contributing to Tremor, you agree that your contributions will be licensed under the [Apache License 2.0](https://github.com/tremorlabs/tremor/blob/main/License) license. By submitting your pull request, you agree to our [Contributor License Agreement (CLA)](https://www.tremor.so/contributors). This agreement clarifies our ability to incorporate your contributions.

package.json

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@
3838
"@babel/preset-env": "^7.24.5",
3939
"@babel/preset-react": "^7.24.1",
4040
"@babel/preset-typescript": "^7.24.1",
41-
"@chromatic-com/storybook": "^1",
41+
"@chromatic-com/storybook": "^1.4.0",
4242
"@mdx-js/react": "^2.3.0",
4343
"@rollup/plugin-commonjs": "^21.1.0",
4444
"@rollup/plugin-node-resolve": "^13.3.0",
@@ -47,20 +47,20 @@
4747
"@semantic-release/commit-analyzer": "^9.0.2",
4848
"@semantic-release/github": "github:semantic-release/github",
4949
"@semantic-release/npm": "github:semantic-release/npm",
50-
"@storybook/addon-a11y": "^8.0.10",
51-
"@storybook/addon-actions": "^8.0.10",
52-
"@storybook/addon-essentials": "^8.0.10",
53-
"@storybook/addon-interactions": "^8.0.10",
54-
"@storybook/addon-links": "^8.0.10",
50+
"@storybook/addon-a11y": "^8.1.1",
51+
"@storybook/addon-actions": "^8.1.1",
52+
"@storybook/addon-essentials": "^8.1.1",
53+
"@storybook/addon-interactions": "^8.1.1",
54+
"@storybook/addon-links": "^8.1.1",
5555
"@storybook/addon-styling-webpack": "^1.0.0",
56-
"@storybook/addon-themes": "^8.0.10",
56+
"@storybook/addon-themes": "^8.1.1",
5757
"@storybook/addon-webpack5-compiler-babel": "^3.0.3",
58-
"@storybook/manager-api": "^8.0.10",
58+
"@storybook/manager-api": "^8.1.1",
5959
"@storybook/mdx2-csf": "^1.1.0",
60-
"@storybook/react": "^8.0.10",
61-
"@storybook/react-webpack5": "^8.0.10",
62-
"@storybook/test": "^8.0.10",
63-
"@storybook/theming": "^8.0.10",
60+
"@storybook/react": "^8.1.1",
61+
"@storybook/react-webpack5": "^8.1.1",
62+
"@storybook/test": "^8.1.1",
63+
"@storybook/theming": "^8.1.1",
6464
"@tailwindcss/forms": "^0.5.7",
6565
"@testing-library/react": "^14.1.2",
6666
"@types/jest": "^29.5.12",
@@ -96,7 +96,7 @@
9696
"rollup-plugin-preserve-directives": "^0.1.1",
9797
"rollup-plugin-typescript-paths": "^1.4.0",
9898
"semantic-release": "^22.0.8",
99-
"storybook": "^8.0.10",
99+
"storybook": "^8.1.1",
100100
"storybook-source-link": "^4.0.1",
101101
"style-loader": "^3.3.3",
102102
"tailwindcss": "^3.4.3",

0 commit comments

Comments
 (0)