Results dictionary should contain a timestamp now #514
Conversation
| def _return_timestamp(self): | ||
| """ | ||
| Return a timestamp | ||
| """ | ||
| timestap = datetime.now().strftime("%H:%M:%S") | ||
| return timestamp | ||
|
|
There was a problem hiding this comment.
Aren't we suppose to use this function somewhere? Or it's just a conventional callback?
There was a problem hiding this comment.
Just an entrypoint, babysteps
There was a problem hiding this comment.
Fair enough, I thought this was ready for the review, sorry 😄 if you want you can mark PRs as draft to make explicit that it's still an ongoing effort 👍
| Return a timestamp | ||
| """ | ||
| timestap = datetime.now().strftime("%H:%M:%S") | ||
| return timestamp |
|
Hey @MMuschner ,
PD: As always, try to add more information in the PR description. Something like Something like that. Keep in mind that the description is the entry point for the reviewer PD2: |
|
@MMuschner Other thing. Be careful linking issues to PRs. Linking means that once the PR is closed, the issue is closed as well. |
|
It's been too long. Thanks for the effort anyway, Mike! |
This PR aims to add the
execution_datetimeof the checks execution to the result dictionary. This is useful to know when were the current checks execute. This is the first part of the implementation to fix #467.