Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Utilize anchors for tabs #4

Open
trevanhetzel opened this issue Jun 30, 2014 · 2 comments
Open

Utilize anchors for tabs #4

trevanhetzel opened this issue Jun 30, 2014 · 2 comments

Comments

@trevanhetzel
Copy link
Owner

Currently, clicking a tab anchor prevents its href from being followed. We should allow hrefs to be followed so you can navigate to a URL with the hash (ex: a2labs.github.io/bare-ninja#accordion)

@ttbarnes
Copy link
Contributor

ttbarnes commented Oct 7, 2014

@trevanhetzel Like this? http://jsfiddle.net/mhb6p6zt/13/show/

So clicking one of the links would allow default behaviour. eg: example.html#test6

I've got some code ready that also prevents default if a tab link only contains a hash tag. Let me know and I can do a PR.

@trevanhetzel
Copy link
Owner Author

I'm not really seeing it in your example. What I'm talking about would allow you to, without clicking a tab anchor, open up that tab by manipulating the URL to have a hash that matches that of the tab you want open.

The more I think about it, the functionality would almost be exactly like this article I wrote that uses the :target selector. Only problem with that is the jumpiness (and :target is not supported in IE8/9).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants