From 26803f8c823c6ae7668f55efe1bd7aef22cf5d99 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jan=20V=C3=A1clav=C3=ADk?= <jvaclavik@gmail.com>
Date: Thu, 30 Jan 2025 14:06:56 +0100
Subject: [PATCH] fix(suite): Dont show update banner until discovery is
 finished (#16602)

---
 .../QuickActions/Update/UpdateNotificationBanner.tsx       | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/packages/suite/src/components/suite/layouts/SuiteLayout/Sidebar/QuickActions/Update/UpdateNotificationBanner.tsx b/packages/suite/src/components/suite/layouts/SuiteLayout/Sidebar/QuickActions/Update/UpdateNotificationBanner.tsx
index dc8e83bc05b..06c47936f20 100644
--- a/packages/suite/src/components/suite/layouts/SuiteLayout/Sidebar/QuickActions/Update/UpdateNotificationBanner.tsx
+++ b/packages/suite/src/components/suite/layouts/SuiteLayout/Sidebar/QuickActions/Update/UpdateNotificationBanner.tsx
@@ -13,7 +13,7 @@ import {
     mapDeviceUpdateToClick,
 } from './updateQuickActionTypes';
 import { Translation, TranslationKey } from '../../../../../Translation';
-import { useDispatch } from '../../../../../../../hooks/suite';
+import { useDiscovery, useDispatch } from '../../../../../../../hooks/suite';
 
 type ContainerProps = { $elevation: Elevation };
 
@@ -77,6 +77,9 @@ export const UpdateNotificationBanner = ({
     onClose,
 }: UpdateNotificationBannerProps) => {
     const dispatch = useDispatch();
+    const { getDiscoveryStatus } = useDiscovery();
+    const discoveryStatus = getDiscoveryStatus();
+    const discoveryInProgress = discoveryStatus && discoveryStatus.status === 'loading';
 
     const translationHeader =
         updateStatusSuite !== 'up-to-date' // Update suite first, because it will contain the newest firmware
@@ -88,7 +91,7 @@ export const UpdateNotificationBanner = ({
             updateStatusSuite !== 'up-to-date' ? updateStatusSuite : updateStatusDevice
         ];
 
-    if (translationHeader === null || translationCallToAction === null) {
+    if (translationHeader === null || translationCallToAction === null || discoveryInProgress) {
         return null;
     }