From c8f5f480d16015cf48730a96aefd22fb0e94c331 Mon Sep 17 00:00:00 2001 From: Martin Homola Date: Thu, 30 Jan 2025 18:29:43 +0100 Subject: [PATCH] refactor(trading): delete dead code of cached account --- .../wallet/constants/tradingBuyConstants.ts | 1 - .../src/actions/wallet/tradingBuyActions.ts | 20 ----------------- .../wallet/trading/form/useTradingBuyForm.tsx | 7 ------ .../wallet/__tests__/tradingReducer.test.ts | 16 -------------- .../src/reducers/wallet/tradingReducer.ts | 22 +------------------ 5 files changed, 1 insertion(+), 65 deletions(-) diff --git a/packages/suite/src/actions/wallet/constants/tradingBuyConstants.ts b/packages/suite/src/actions/wallet/constants/tradingBuyConstants.ts index f30a7cf7f1a..98baed50ae2 100644 --- a/packages/suite/src/actions/wallet/constants/tradingBuyConstants.ts +++ b/packages/suite/src/actions/wallet/constants/tradingBuyConstants.ts @@ -7,5 +7,4 @@ export const SAVE_QUOTE = '@trading-buy/save_buy_quote'; export const CLEAR_QUOTES = '@trading-buy/clear_buy_quotes'; export const VERIFY_ADDRESS = '@trading-buy/verify_address'; export const SAVE_TRANSACTION_ID = '@trading-buy/save_transaction_id'; -export const SAVE_CACHED_ACCOUNT_INFO = '@trading-buy/save_cached_account_info'; export const DISPOSE = '@trading-buy/dispose'; diff --git a/packages/suite/src/actions/wallet/tradingBuyActions.ts b/packages/suite/src/actions/wallet/tradingBuyActions.ts index 351a1e2f011..1cb7d4312f5 100644 --- a/packages/suite/src/actions/wallet/tradingBuyActions.ts +++ b/packages/suite/src/actions/wallet/tradingBuyActions.ts @@ -33,13 +33,6 @@ export type TradingBuyAction = | { type: typeof TRADING_BUY.SAVE_TRANSACTION_DETAIL_ID; transactionId: string } | { type: typeof TRADING_BUY.SAVE_QUOTE_REQUEST; request: BuyTradeQuoteRequest } | { type: typeof TRADING_BUY.VERIFY_ADDRESS; addressVerified: string | undefined } - | { - type: typeof TRADING_BUY.SAVE_CACHED_ACCOUNT_INFO; - symbol: Account['symbol']; - index: Account['index']; - accountType: Account['accountType']; - shouldSubmit?: boolean; - } | { type: typeof TRADING_BUY.SAVE_QUOTES; quotes: BuyTrade[]; @@ -161,19 +154,6 @@ export const saveTransactionDetailId = (transactionId: string): TradingBuyAction transactionId, }); -export const saveCachedAccountInfo = ( - symbol: Account['symbol'], - index: number, - accountType: Account['accountType'], - shouldSubmit = false, -): TradingBuyAction => ({ - type: TRADING_BUY.SAVE_CACHED_ACCOUNT_INFO, - symbol, - index, - accountType, - shouldSubmit, -}); - export const saveQuotes = (quotes: BuyTrade[]): TradingBuyAction => ({ type: TRADING_BUY.SAVE_QUOTES, quotes, diff --git a/packages/suite/src/hooks/wallet/trading/form/useTradingBuyForm.tsx b/packages/suite/src/hooks/wallet/trading/form/useTradingBuyForm.tsx index 300caa6400c..c8d6acd4d0b 100644 --- a/packages/suite/src/hooks/wallet/trading/form/useTradingBuyForm.tsx +++ b/packages/suite/src/hooks/wallet/trading/form/useTradingBuyForm.tsx @@ -268,13 +268,6 @@ export const useTradingBuyForm = ({ const goToOffers = async () => { await handleChange(); - dispatch( - tradingBuyActions.saveCachedAccountInfo( - account.symbol, - account.index, - account.accountType, - ), - ); navigateToBuyOffers(); }; diff --git a/packages/suite/src/reducers/wallet/__tests__/tradingReducer.test.ts b/packages/suite/src/reducers/wallet/__tests__/tradingReducer.test.ts index 693b0284969..3a1c715b0ac 100644 --- a/packages/suite/src/reducers/wallet/__tests__/tradingReducer.test.ts +++ b/packages/suite/src/reducers/wallet/__tests__/tradingReducer.test.ts @@ -244,22 +244,6 @@ describe('settings reducer', () => { ).toEqual(initialState); }); - it('TRADING_BUY.SAVE_CACHED_ACCOUNT_INFO', () => { - const cachedAccountInfo = { - symbol: 'btc', - index: 1, - accountType: 'segwit', - shouldSubmit: true, - }; - - expect( - tradingReducer(undefined, { - type: TRADING_BUY.SAVE_CACHED_ACCOUNT_INFO, - ...cachedAccountInfo, - } as any), - ).toEqual({ ...initialState, buy: { ...initialState.buy, cachedAccountInfo } }); - }); - it('TRADING_EXCHANGE.SAVE_EXCHANGE_INFO', () => { const exchangeInfo: ExchangeInfo = { providerInfos: {}, diff --git a/packages/suite/src/reducers/wallet/tradingReducer.ts b/packages/suite/src/reducers/wallet/tradingReducer.ts index 5ba7cb0dd74..ab38f9f75ce 100644 --- a/packages/suite/src/reducers/wallet/tradingReducer.ts +++ b/packages/suite/src/reducers/wallet/tradingReducer.ts @@ -28,7 +28,7 @@ import type { ExchangeInfo } from 'src/actions/wallet/tradingExchangeActions'; import type { SellInfo } from 'src/actions/wallet/tradingSellActions'; import type { AppState, Action as SuiteAction } from 'src/types/suite'; import { TradingPaymentMethodListProps } from 'src/types/trading/trading'; -import type { Account, WalletAction } from 'src/types/wallet'; +import type { WalletAction } from 'src/types/wallet'; import type { Trade } from 'src/types/wallet/tradingCommonTypes'; export interface ComposedTransactionInfo { @@ -55,12 +55,6 @@ interface Buy extends TradingTradeCommonProps { quotesRequest?: BuyTradeQuoteRequest; quotes: BuyTrade[] | undefined; selectedQuote: BuyTrade | undefined; - cachedAccountInfo: { - accountType?: Account['accountType']; - index?: Account['index']; - symbol?: Account['symbol']; - shouldSubmit?: boolean; - }; addressVerified: string | undefined; } @@ -113,12 +107,6 @@ export const initialState: State = { buyInfo: undefined, quotesRequest: undefined, selectedQuote: undefined, - cachedAccountInfo: { - accountType: undefined, - index: undefined, - symbol: undefined, - shouldSubmit: false, - }, quotes: [], addressVerified: undefined, }, @@ -191,14 +179,6 @@ export const tradingReducer = ( case TRADING_BUY.VERIFY_ADDRESS: draft.buy.addressVerified = action.addressVerified; break; - case TRADING_BUY.SAVE_CACHED_ACCOUNT_INFO: - draft.buy.cachedAccountInfo = { - symbol: action.symbol, - index: action.index, - accountType: action.accountType, - shouldSubmit: action.shouldSubmit, - }; - break; case TRADING_BUY.DISPOSE: draft.buy.addressVerified = undefined; break;