Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Coin Enabling - message system compliance #13470

Closed
vytick opened this issue Jul 23, 2024 · 4 comments · Fixed by #14037
Closed

Coin Enabling - message system compliance #13470

vytick opened this issue Jul 23, 2024 · 4 comments · Fixed by #14037
Assignees
@vytick
Labels
mobile Suite Lite issues and PRs QA OK Issue passed QA without any blocker
Milestone
Mobile - coin ena...

Comments

@vytick
Copy link
Contributor

vytick commented Jul 23, 2024 •
edited
Loading

Make sure that message system can correctly detect which coins are enabled to correctly show banner based on this.
@vytick vytick added the mobile Suite Lite issues and PRs label Jul 23, 2024
@vytick vytick added this to the Mobile - coin enabling milestone Jul 23, 2024
@matejkriz matejkriz moved this to 🎯 To do in Suite Mobile Jul 29, 2024
@vytick vytick self-assigned this Aug 29, 2024
@vytick vytick moved this from 🎯 To do to 🏃‍♀️ In progress in Suite Mobile Aug 29, 2024
@vytick vytick mentioned this issue Aug 30, 2024
Merged
@github-project-automation github-project-automation bot moved this from 🏃‍♀️ In progress to 👀 Dev done in Suite Mobile Sep 2, 2024
@vytick vytick moved this from 👀 Dev done to 🤝 Needs QA in Suite Mobile Sep 2, 2024
@vytick vytick mentioned this issue Sep 9, 2024
Closed
@STew790
Copy link
Contributor

STew790 commented Sep 17, 2024

QA NOK
#14233 this is still not merged 🤔

@STew790 STew790 moved this from 🤝 Needs QA to 🎯 To do in Suite Mobile Sep 17, 2024
@STew790 STew790 added the QA NOK Issue doesn't pass the QA and some changes are needed. label Sep 17, 2024
@matejkriz
Copy link
Member

QA NOK #14233 this is still not merged 🤔

Now it's released on develop, you can test it.

@matejkriz matejkriz moved this from 🎯 To do to 🤝 Needs QA in Suite Mobile Sep 17, 2024
@matejkriz matejkriz moved this from 🤝 Needs QA to 🏃‍♀️ In progress in Suite Mobile Sep 23, 2024
@matejkriz matejkriz mentioned this issue Sep 23, 2024
Merged
@vytick
Copy link
Contributor Author

vytick commented Sep 27, 2024

@STew790 can be tested now with a bit different testsing message (for nmc, dash, btg, vtc)

@vytick vytick moved this from 🏃‍♀️ In progress to 🤝 Needs QA in Suite Mobile Sep 27, 2024
@STew790
Copy link
Contributor

STew790 commented Sep 30, 2024

QA OK
Yes, this is now working correctly for me 🎉

@STew790 STew790 moved this from 🤝 Needs QA to ✅ Approved in Suite Mobile Sep 30, 2024
@STew790 STew790 added QA OK Issue passed QA without any blocker and removed QA NOK Issue doesn't pass the QA and some changes are needed. labels Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vytick vytick

Labels
mobile Suite Lite issues and PRs QA OK Issue passed QA without any blocker
Projects
Suite Mobile
Status: ✅ Approved
Milestone
Mobile - coin enabling
Development

Successfully merging a pull request may close this issue.

feat(suite-native): use enabled networks for msg system settings validation trezor/trezor-suite
3 participants
@vytick @matejkriz @STew790