Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

connect - popup might not be needed #14527

Open
mroz22 opened this issue Sep 25, 2024 · 3 comments
Open

connect - popup might not be needed #14527

mroz22 opened this issue Sep 25, 2024 · 3 comments
Assignees
Labels
connect Connect API related (ie. fee calculation)

Comments

@mroz22
Copy link
Contributor

mroz22 commented Sep 25, 2024

Consider not opening the connect-popup if we can tell beforehand that we won't need it.

unskip skipped test in #14517

@mroz22 mroz22 added the connect Connect API related (ie. fee calculation) label Sep 25, 2024
@github-project-automation github-project-automation bot moved this to 🎯 To do in Suite Desktop Sep 25, 2024
@martykan martykan self-assigned this Sep 25, 2024
@Hannsek
Copy link
Contributor

Hannsek commented Sep 25, 2024

In which situation we currently open popup when we don't need it?

@martykan
Copy link
Member

For example getFeatures for an already remembered device with granted permissions

@bsl
Copy link

bsl commented Oct 24, 2024

Upvote. Coming from Ledger, I'm finding it disturbing that Metamask wants to open a Trezor domain and download over a meg of minified Javascript just to sign a tx. I don't understand what the rationale is, and I'm disturbed by how little discussion there is about what data if any is being sent when that page is opened. If that needs to happen once in order to grant permission to export public keys, that seems fine, but then please remember it and don't open this popup on every subsequent tx. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
connect Connect API related (ie. fee calculation)
Projects
Status: 🎯 To do
Development

No branches or pull requests

4 participants