Conversation
3a4f216 to
18cc925
Compare
|
Seems to work fine already - see https://github.com/trezor/trezor-suite/actions/runs/11105572536 Consideration - instead (in addition) to saving this as GH-Actions artifacts, it might be beneficial to save it on
|
|
I am not familiar with I am totally ok for using it for this artifact. It should be uploaded probably only for develop branch so that it doesn't bloat too much. |
0780506 to
7f208a6
Compare
| - name: Upload dist to dev server | ||
| shell: bash | ||
| env: | ||
| DEPLOY_PATH: s3://dev.suite.sldev.cz/transport-bridge/dist |
There was a problem hiding this comment.
I am ok with it but maybe, for consistency purposes - shouldn't it contain branch name here? consider other jobs
There was a problem hiding this comment.
I have deleted the branch name on purpose, as it will only run in develop branch ... but will include it again
|
|
||
| - name: Install deps and build libs | ||
| run: | | ||
| yarn install --immutable |
There was a problem hiding this comment.
is this full yarn install needed? wouldn't yarn focus to transport-bridge folder suffice?
There was a problem hiding this comment.
No idea at all here, but will try it
There was a problem hiding this comment.
this way it installs all the dependencies. In frequently run jobs, it makes sense to optimize it using yarn focus. here it is less relevant but still a good practice to follow if possible
6436b63 to
d40acdb
Compare
| branches: | ||
| - develop | ||
| pull_request: | ||
| types: [labeled] |
There was a problem hiding this comment.
This makes no sense; it will build a node bridge for any PR that you add a label to. Why??
There was a problem hiding this comment.
Because I do not know workflow syntax well and I copied it like this from some other .yml file. Agreed that it is redundant, I will remove it.
Do you have some other possible improvements, when I will be already making another PR with changes?
There was a problem hiding this comment.
This was the only thing that i noticed
There was a problem hiding this comment.
Thanks for that. I created a PR for it - #14742
Tries to build an exportable artifact with bin.js file containing node-bridge code
To be used by
tenv- taking the latest artefact fromdevelop