Improve error handling in firmware revision check #14626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
komret
requested review from
MiroslavProchazka,
mroz22,
szymonlesisz and
martykan
as code owners
| @@ -59,6 +59,7 @@ export const checkFirmwareRevision = async ({ | |||
| deviceRevision, | |||
| expectedRevision, | |||
| }: CheckFirmwareRevisionParams): Promise<FirmwareRevisionCheckResult> => { | |||
| console.log(expectedRevision); | |||
komret
force-pushed
the
fix/revision-check-error
branch
from
ae23c46 to
feac8db
Compare
packages/suite/src/components/suite/banners/SuiteBanners/FirmwareRevisionCheckBanner.tsx
Outdated
Show resolved
Hide resolved
|
Here's an example of a poorly formatted JSON which cannot be parsed and causes an error:. I'll fix it in another PR. |
peter-sanderson
approved these changes
Sep 30, 2024
|
/rebase |
|
Start rebasing: https://github.com/trezor/trezor-suite/actions/runs/11109207009 |
trezor-ci
force-pushed
the
fix/revision-check-error
branch
from
b81ec4f to
fb63794
Compare
|
commits organized nicely 👏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously, whenever there was an error while downloading and reading the remote
releases.jsonfile, the user would be instructed to go online. This message is misleading when there is some other cause for an error such as incorrect URL or incorrectly formatted JSON file.It would be nice to log these types of errors to Sentry, but then we'd have to store the stack trace somewhere temporarily before firing the event... maybe next step.
Copy could be improved and the KB article updated.
QA: This cannot be tested without some code modification. But you can test that I did not break the original flow.
Related Issue
Resolve
Screenshots: