Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misaligned fiat value of network fee in send and swap section #15762

Closed
bosomt opened this issue Dec 4, 2024 · 1 comment · Fixed by #15831
Closed

Misaligned fiat value of network fee in send and swap section #15762

bosomt opened this issue Dec 4, 2024 · 1 comment · Fixed by #15831
Assignees
@seibei-iguchi
Labels
bug Something isn't working as expected

Comments

@bosomt
Copy link
Contributor

bosomt commented Dec 4, 2024

Describe the bug
Misaligned fiat value of network fee in send and swap section

Steps to reproduce:

  1. Navigate to send
  2. Press send all
  3. Check fee section

Info:

  • Suite version: web 25.1.0 (2ddabdc)
  • Browser: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/131.0.0.0 Safari/537.36
  • OS: MacIntel
  • Screen: 1512x982
  • Device: Trezor T3T1 2.8.5 regular (revision a61e783448043760a7c925e017bd08a4673a61c8)
  • Transport: WebUsbTransport

Screenshots:

Screen.Recording.2024-12-04.at.10.51.08.mov
Screenshot 2024-12-04 at 10 38 27 Screenshot 2024-12-04 at 10 37 46
@github-project-automation github-project-automation bot moved this to 🎯 To do in Suite Desktop Dec 4, 2024
@bosomt bosomt added the bug Something isn't working as expected label Dec 4, 2024
@trezor trezor deleted a comment Dec 4, 2024
@seibei-iguchi seibei-iguchi self-assigned this Dec 5, 2024
@seibei-iguchi seibei-iguchi linked a pull request Dec 9, 2024 that will close this issue
fix(suite): fix FiatValue component wrapping #15831
Merged
@github-project-automation github-project-automation bot moved this from 🎯 To do to 🤝 Needs QA in Suite Desktop Dec 9, 2024
@bosomt bosomt moved this from 🤝 Needs QA to ✅ Approved in Suite Desktop Dec 11, 2024
@bosomt
Copy link
Contributor Author

bosomt commented Dec 11, 2024

QA OK

Info:

  • Suite version: desktop 24.12.1 (ec8321d)
  • Browser: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) TrezorSuite/24.12.1 Chrome/128.0.6613.186 Electron/32.2.6 Safari/537.36
  • OS: MacIntel
  • Screen: 1512x982
  • Device: Trezor T3T1 2.8.6 regular (revision 17f2a3256b2631823c2bad1855fab61b27985fd2)
  • Transport: BridgeTransport 2.0.33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@seibei-iguchi seibei-iguchi

Labels
bug Something isn't working as expected
Projects
Suite Desktop
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(suite): fix FiatValue component wrapping trezor/trezor-suite
2 participants
@seibei-iguchi @bosomt