Feat: solve hash check on install false positives #15772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Expo preview is ready!
|
Lemonexe
commented
Dec 5, 2024
| @@ -86,6 +87,17 @@ export const prepareFirmwareReducer = createReducerWithExtraDeps(initialState, ( | |||
| state.cachedDevice = payload; | |||
| }) | |||
| .addCase(deviceActions.addButtonRequest, extra.reducers.addButtonRequestFirmware) | |||
| .addCase(deviceActions.connectDevice, (state, { payload: { device } }) => { | |||
There was a problem hiding this comment.
💭 Similar condition in deviceReducer, but this is simpler because we don't care about unacquired devices. Then it's just one action we need to match, so we can use the simpler addCase instead of addMatcher
peter-sanderson
approved these changes
Dec 5, 2024
Lemonexe
force-pushed
the
feat/hash-check-on-install-false-positives
branch
from
e5cb614 to
509ff96
Compare
Lemonexe
commented
Dec 5, 2024
| @@ -311,6 +311,8 @@ const storageMiddleware = (api: MiddlewareAPI<Dispatch, AppState>) => { | |||
| case FORM_DRAFT.REMOVE_DRAFT: | |||
| storageActions.removeFormDraft(action.key); | |||
| break; | |||
|
|
|||
| case deviceActions.connectDevice.type: // so that firmwareReducer.addCase for the same action is persisted | |||
There was a problem hiding this comment.
this works because next(action) is called at beginning.
So the firmwareReducer.addCase does its thing first, and only then this case block is executed to persist the newly updated state.firmware.firmwareHashInvalid.
komret
reviewed
Dec 5, 2024
| @@ -164,7 +161,6 @@ export const firmwareUpdate = createThunk< | |||
| // device failed to respond to the hash check, consider the firmware counterfeit | |||
There was a problem hiding this comment.
Please edit the comment, too.
komret
approved these changes
Dec 5, 2024
|
/rebase |
|
Start rebasing: https://github.com/trezor/trezor-suite/actions/runs/12182760808 |
trezor-ci
force-pushed
the
feat/hash-check-on-install-false-positives
branch
from
b051dd0 to
726fed6
Compare
|
QA OK webUSB
Info:
dev app
Info:
|
|
QA OK APP
WEB
Info:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checkout testing branch to simulate hash mismatch, or other error (separate commits for each)
Related issue
😞 Reopens #5868
Screenshots
hash mismatch is exonerated.webm