Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modals on tx details are a broken / jumping #15852

Closed
STew790 opened this issue Dec 9, 2024 · 1 comment · Fixed by #15853
Closed

Modals on tx details are a broken / jumping #15852

STew790 opened this issue Dec 9, 2024 · 1 comment · Fixed by #15853
Assignees
@vytick
Labels
bug Something isn't working as expected mobile Suite Lite issues and PRs QA OK Issue passed QA without any blocker

Comments

@STew790
Copy link
Contributor

STew790 commented Dec 9, 2024

Describe the bug
When you open a modal on some tx detail, it jumps a little from top to bottom.

Info:

  • Mobile Suite Version: 24.11.3 f6fa667
  • OS: Android

How to reproduce
Steps to reproduce the behavior:

  1. Go to any account of any coin
  2. Go to any tx detail
  3. Open any info from that tx detail

Screenshots

1000014307.mp4
@STew790 STew790 added bug Something isn't working as expected mobile Suite Lite issues and PRs labels Dec 9, 2024
@github-project-automation github-project-automation bot moved this to 🎯 To do in Suite Mobile Dec 9, 2024
@vytick vytick self-assigned this Dec 9, 2024
@vytick vytick moved this from 🎯 To do to 🏃‍♀️ In progress in Suite Mobile Dec 9, 2024
@vytick vytick mentioned this issue Dec 9, 2024
Merged
@vytick vytick moved this from 🏃‍♀️ In progress to 🤝 Needs QA in Suite Mobile Dec 10, 2024
@STew790
Copy link
Contributor Author

STew790 commented Dec 10, 2024

QA OK
Modals looking very smooth 🖤

Info
24.11.3 3dc31ff

@STew790 STew790 moved this from 🤝 Needs QA to ✅ Approved in Suite Mobile Dec 10, 2024
@STew790 STew790 added the QA OK Issue passed QA without any blocker label Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vytick vytick

Labels
bug Something isn't working as expected mobile Suite Lite issues and PRs QA OK Issue passed QA without any blocker
Projects
Suite Mobile
Status: ✅ Approved
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(suite-native): bottomsheet container has fixed size trezor/trezor-suite
2 participants
@vytick @STew790